Merged
Conversation
The `{{-` (left-trim) on the semverCompare conditional was eating the
newline after the `---` document separator, producing the invalid token
`---apiVersion: networking.k8s.io/v1`. Removed the leading dash to
preserve the newline.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Oh, come on. |
- test-api-documents.yaml: DELETE used document_id=test instead of test-document-id-13, so the delete assertion was vacuously passing - httproute-extra.yaml: added guard comment above the --- separator to prevent the same whitespace trimming bug as ingress-extra.yaml - values.yaml: fixed typos (amd→and, spreadhseet→spreadsheet, doubled "will use"), reordered customTags annotations - CLAUDE.md: added Pre-commit Checklist section with helm-docs and helm-schema reminders Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Helm's linter misparses `{{- /* ... */ }}` (trim-dash followed by
comment opener) as a broken action. Switched to a plain YAML comment.
Added Template Pitfalls section to CLAUDE.md documenting both the
document separator and template comment gotchas.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Go's template engine parses all {{ delimiters before YAML, so
even {{ inside a YAML comment is treated as a template action.
Rewrote the comment to avoid template syntax entirely. Added
this as a third pitfall in CLAUDE.md.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lazyoldbear
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
{{-(left-trim) on the semverCompare conditional was eating the newline after the---document separator, producing the invalid token---apiVersion: networking.k8s.io/v1. Removed the leading dash to preserve the newline.