Skip to content

🩹 [Patch]: Use GitHub App again and some log and file formatting#45

Merged
Marius Storhaug (MariusStorhaug) merged 5 commits intomainfrom
fix
Jul 26, 2025
Merged

🩹 [Patch]: Use GitHub App again and some log and file formatting#45
Marius Storhaug (MariusStorhaug) merged 5 commits intomainfrom
fix

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug Marius Storhaug (MariusStorhaug) commented Jul 23, 2025

This pull request updates the workflow and script for automating the FontsData update process. Key changes include integration with GitHub App credentials, enhanced error handling, and formatting updates for better readability. The changes also streamline the process for detecting updates, committing changes, and creating pull requests.

Workflow updates:

  • .github/workflows/Update-FontsData.yml: Added GitHub App credentials (ClientID and PrivateKey) for secure authentication during the update process. Removed permissions as these grant the GITHUB_TOKEN permissions, which is no longer used.

Script enhancements:

  • scripts/Update-FontsData.ps1: Improved command execution to capture output and handle multiline results, returning formatted output when applicable.
  • scripts/Update-FontsData.ps1: Updated JSON formatting for FontsData.json to include indentation for better readability.
  • scripts/Update-FontsData.ps1: Enhanced logging and messaging, including clearer notices for no updates, summary of changes, and improved pull request titles and descriptions. [1] [2]

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copilot AI review requested due to automatic review settings July 23, 2025 15:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the GitHub workflow permissions and enhances the font update script by implementing GitHub App authentication and improving output formatting. The changes move from token-based authentication to GitHub App authentication while restructuring the script logic for better organization and clearer output.

Key changes:

  • Replaces GitHub token permissions with GitHub App authentication using client ID and private key
  • Restructures the PowerShell script with better logical grouping and enhanced output formatting
  • Improves error handling and adds GitHub-specific output features like step summaries and notices

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/Update-FontsData.yml Removes explicit permissions and adds GitHub App credentials for authentication
scripts/Update-FontsData.ps1 Enhances script with GitHub App connection, better output handling, and improved logical flow organization

@MariusStorhaug Marius Storhaug (MariusStorhaug) changed the title 🩹 [Patch]: Simplify permissions and enhance font update script logic 🩹 [Patch]: Use GitHub App again and some log and file formatting Jul 26, 2025
@MariusStorhaug Marius Storhaug (MariusStorhaug) merged commit 34cbcf7 into main Jul 26, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant