fix: replace bare except with specific exceptions in solve_L, fix adj_cost docstring typo#1091
Open
suyash469 wants to merge 1 commit intoPSLmodels:masterfrom
Open
Conversation
…_cost docstring typo - firm.py solve_L(): Replace bare except: with except (ValueError, TypeError):. The try/except exists only to detect whether K_g is an ndarray (comparison raises ValueError) or an incompatible type (TypeError). A bare except catches KeyboardInterrupt, SystemExit, MemoryError and other critical signals, making long OG-Core runs impossible to interrupt and masking real bugs silently. - firm.py adj_cost(): Fix typo in docstring: 'adjstment' -> 'adjustment'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small real bug fixes in ogcore/firm.py.
Changes
1. solve_L() — Replace bare
except:withexcept (ValueError, TypeError):The
try/exceptblock exists solely to detect whetherK_gis a NumPy array(comparing an array to a scalar raises
ValueError) or an incompatible type(
TypeError). A bareexcept:silently catchesKeyboardInterrupt,SystemExit,and
MemoryError, making long OG-Core runs impossible to interrupt and maskingreal errors silently.
2. adj_cost() — Fix docstring typo
'adjstment'→'adjustment'Validation
exceptclauses remain in firm.py via AST check