Add parameter for minimum consumption amounts#1085
Merged
rickecon merged 21 commits intoPSLmodels:masterfrom Jan 18, 2026
Merged
Add parameter for minimum consumption amounts#1085rickecon merged 21 commits intoPSLmodels:masterfrom
rickecon merged 21 commits intoPSLmodels:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 72.92% 73.19% +0.27%
==========================================
Files 21 21
Lines 5122 5137 +15
==========================================
+ Hits 3735 3760 +25
+ Misses 1387 1377 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
All tests, but one, pass locally: The failing test is |
Member
Author
|
@rickecon, despite the failing test, this PR is ready for your review. Perhaps you can try the failing test on your machine. I don't recall that failing before, but it's odd since nothing was changed related to the function tested. |
rickecon
approved these changes
Jan 18, 2026
Member
|
@jdebacker. This looks great. Thanks. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter,
c_minthat represents the minimum consumption amounts for eachiconsumption good. This parameter was already outlined in the theory, but hadn't bee included in the model code.Resolves Issue #982.