Remove initial_guess_w_SS from default params#1042
Merged
rickecon merged 20 commits intoPSLmodels:masterfrom Aug 16, 2025
Merged
Remove initial_guess_w_SS from default params#1042rickecon merged 20 commits intoPSLmodels:masterfrom
initial_guess_w_SS from default params#1042rickecon merged 20 commits intoPSLmodels:masterfrom
Conversation
This was referenced Aug 3, 2025
rickecon
reviewed
Aug 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 72.67% 72.67%
=======================================
Files 20 20
Lines 5068 5068
=======================================
Hits 3683 3683
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rickecon
approved these changes
Aug 15, 2025
Member
|
@jdebacker. I just submitted a PR to your branch. Once you review and merge that PR, I can merge this PR. |
Final changes to initial_w branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
initial_guess_w_SSfrom default params per suggestions in Issue #1039.