Add Disk Availability Policy support to Az.Compute #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes Azure SDK's existing Disk Availability Policy feature through PowerShell cmdlets, enabling configuration of VM behavior when disks experience I/O degradation.
Changes
AvailabilityPolicyproperty toPSDiskandPSDiskUpdate-ActionOnDiskDelayparameter toNew-AzDiskConfigandNew-AzDiskUpdateConfigNone(VM restarts on slow I/O) |AutomaticReattach(detach/reattach disk on I/O failure)Test-DiskAvailabilityPolicycovering create and update scenariosUsage
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1mcvsblobprodwus2174.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)1n8vsblobprodwus2184.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)2d2vsblobprodwus2127.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)40vvsblobprodwus2135.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)5azvsblobprodwus2162.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)5o1vsblobprodwus2115.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)6yfvsblobprodwus2121.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)7t8vsblobprodwus2168.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)84hvsblobprodwus2148.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)8wdvsblobprodwus2137.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)b15vsblobprodwus2164.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)b53vsblobprodwus2154.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)ba0vsblobprodwus2130.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)balvsblobprodwus2129.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)cbvvsblobprodwus2131.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)cffvsblobprodwus218.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)d94vsblobprodwus2119.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)ezcvsblobprodwus2170.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)faxvsblobprodwus2122.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)g3xvsblobprodwus2151.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)h8evsblobprodwus2120.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)i01vsblobprodwus216.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)ia4vsblobprodwus2112.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)isvvsblobprodwus2147.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)jhgvsblobprodwus2167.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)jqivsblobprodwus2187.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)k4pvsblobprodwus2140.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)kafvsblobprodwus2165.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)ldhvsblobprodwus2153.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)mt2vsblobprodwus2110.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)nudvsblobprodwus214.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)ox9vsblobprodwus2149.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)p2tvsblobprodwus2189.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)tn2vsblobprodwus2124.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)vd2vsblobprodwus2150.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)vm9vsblobprodwus2190.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)wlnvsblobprodwus2188.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)x0dvsblobprodwus2111.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)xofvsblobprodwus2114.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)y1rvsblobprodwus2136.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)y5lvsblobprodwus2179.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)yf8vsblobprodwus212.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Azure.PowerShell.sln -c Debug -fl /flp1:logFile=/home/REDACTED/work/azure-powershell/azure-powershell/artifacts/Build.log;verbosity=quiet(dns block)zaxvsblobprodwus215.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)zugvsblobprodwus2169.vsblob.vsassets.io/usr/bin/dotnet build /home/REDACTED/work/azure-powershell/azure-powershell/tools/VersionController/VersionController.Netcore.csproj -c Debug(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>{ Az.Compute} - {Disk Availability Policy}</issue_title>
<issue_description>
Guidelines
The purpose of the Azure PowerShell design review is to ensure that the cmdlets follow the same pattern across the Azure modules. An early design review reduces the risk of unnecessary implementation changes caused by a cmdlet syntax design change.
Please ensure your cmdlets comply with the design guidelines outlined in the PowerShell Design Guidelines document.
Please generate cmdlets syntax using
GenerateCmdletDesignMarkdown.ps1for review if your cmdlet is generated from API spec directly by Autorest.PowerShell.Create
$rgname =
$loc =
New-AzResourceGroup -Name $rgname -Location $loc -Force
$diskName =
$diskConfig = New-AzDiskConfig -ActionOnDiskDelay 'AutomaticReattach' -Disk $diskConfig
$disk = Get-AzDisk -ResourceGroupName $rgname -DiskName $diskName
Update
New-AzDiskUpdateConfig -ActionOnDiskDelay 'None' | Update-AzDisk -ResourceGroupName $rgname -DiskName $diskName;
If you just add parameter to existing cmdlets and parameter definition complies with guideline, the design review is not expected.
Have you read above statement?
{ Yes}Service Release Details
Is this an Embargoed Preview, A Public Preview, or a General Release?
{ Public Preview }What is the expected service release date?
{ 10/2 }Which Powershell module are these changes being made in?
{ Az.Compute }Contact Information
Main developer contacts (emails + github aliases)
{ pramb }PM contact (email + github alias)
{ vimohand }Other people who should attend a design review (email)
{ vikramd }High Level Scenarios
Describe how your feature is intended to be used by customers.
{ properties.availabilityPolicy.actionOnDiskDelay. Values: None and AutomaticReAttach}Piping scenarios / how these cmdlets are used with existing cmdlets
{ New-AzDiskConfig -availabilityPolicy.actionOnDiskDelay "AutomaticReattach" }New-AzDiskUpdateConfig (Az.Compute) | Microsoft Learn as well. Any place where customer can set/update the property will need itSample of end-to-end usage
Please provide comprehensive examples that don't assume additional setup. It helps the audience understand your feature.
{ New-AzDiskConfig -availabilityPolicy.actionOnDiskDelay "AutomaticReattach" }Syntax changes
Indicate if you are requesting an edit to existing cmdlets, adding new cmdlets, or both. Then edit the corresponding section below.
New Cmdlet
List the new cmdlet names.
List the parameters for the new cmdlet(s) and the parameter types.
Please describe the business logic of the cmdlet and parameters here.
Link to cmdlet help markdown file generated by platyPS or sample syntax. The below is an example.:
Changed cmdlet
List the names of the cmdlets that are being edited.
List the new parameters for the cmdlet, the parameter types, and their allowed values if applicable.
Please describe the new business logic of the cmdlet and parameters here.
Link to diff between markdown help files, or sample syntax as above.
Indicate which parameter sets on the cmdlet are affected by this change.
Specific test cases
Please provide a link to the API tests that exist for this feature.
{ [Azure/azure-rest-api-specs#34917](https://github.com/Azure/azure-rest-api-specs/pull/34917)}Additional information
Link to the OpenAPI (swagger) spec -
Link to any other Github work related to this request
Indicate any feature flags or restrictions on the changes provided in this design specification.