Merged
Conversation
Ben-Drucker
commented
Oct 16, 2025
| }))) | ||
| set.seed(seed) | ||
| seed_seq <- sample(-.Machine$integer.max:.Machine$integer.max, size = K) | ||
| seed_seq <- sample(1:.Machine$integer.max, size = K) |
Author
There was a problem hiding this comment.
Boruta's underlying random forest engine, ranger::ranger uses C++ code that only accepts uints as random seeds, i.e., positive integers. Using a negative caused reproducibility issues.
| if(sel.feat){ | ||
| features.sel <- FUN(x=dSet[!i,features], | ||
| y=dSet[!i,response], seed = seed) | ||
| y=dSet[!i,response], seed = seed, ...) |
Author
There was a problem hiding this comment.
This is not directly related to reproducibility, but adds the ability to pass additional arguments to Boruta::Boruta
Comment on lines
-186
to
-188
| varSelRF = select_features_varSelRF, | ||
| varSelRF = function(x, y, ...) select_features_varSelRF(x,y), | ||
| Boruta = function(x,y, ...) select_features_Boruta(x,y,...), | ||
| top = select_features_top) |
Author
There was a problem hiding this comment.
Remove ... from being passed to non-Boruta feature selection methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: Makes it possible to get exactly the same output, if running the same exact command (on a given computer). See comments in code for explanation of the changes.
Caveat: Exact reproduciblity will likely not hold across computing machines and/or operating systems. The reason is explained here.