Skip to content

Conversation

@jykr
Copy link

@jykr jykr commented Dec 18, 2024

Observation modeled to have error with Normal distribution with mean field error and identity link function. i.e.,

$$ y=X\beta + a + \epsilon $$

$$ \epsilon \sim \mathcal{N}(0, \mathrm{diag}(\vec{\sigma^2})) $$

Copy link
Collaborator

@ilia-kats ilia-kats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this. Looks good in general (I've only had a cursory look at the _do_test implementation, I trust that it's correct), but a few things aren't clear to me (see the specific comments).

Copy link
Collaborator

@ilia-kats ilia-kats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Could you just run the black formatter on the code?

@ilia-kats ilia-kats merged commit 3703cef into PMBio:master Dec 20, 2024
1 check passed
@ilia-kats
Copy link
Collaborator

Great, thank you.

@jykr
Copy link
Author

jykr commented Dec 20, 2024

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants