L1 tests reboot device #84
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepanVovkPLV
requested review from
SerhiyBoikoPLV,
anton7811 and
yuriilisovskyi
StepanVovkPLV
commented
Mar 22, 2023
| yield | ||
| devices = await _get_dent_devs_from_testbed(testbed) | ||
| to_reboot = [dev.reboot() for dev in devices] | ||
| # up_ports = [dev.run_cmd("sudo onlpdump -S") for dev in devices] |
Collaborator
Author
There was a problem hiding this comment.
Can not perform onlpdump on the device. -> cmd not found
StepanVovkPLV
force-pushed
the
l1_tests_reboot_device
branch
4 times, most recently
from
bde955a to
4ba1a94
Compare
DentOS_Framework/DentOsTestbed/src/dent_os_testbed/test/conftest.py
Outdated
Show resolved
Hide resolved
StepanVovkPLV
force-pushed
the
l1_tests_reboot_device
branch
3 times, most recently
from
761b676 to
35ca1d6
Compare
yuriilisovskyi
approved these changes
Apr 6, 2023
yuriilisovskyi
force-pushed
the
l1_tests_reboot_device
branch
from
35ca1d6 to
131ad5d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
StepanVovkPLV
force-pushed
the
l1_tests_reboot_device
branch
from
131ad5d to
20ffb68
Compare
This comment was marked as resolved.
This comment was marked as resolved.
StepanVovkPLV
force-pushed
the
l1_tests_reboot_device
branch
from
f410ad9 to
5b01ffb
Compare
SerhiyBoikoPLV
requested changes
Jun 16, 2023
Comment on lines
+100
to
+103
| if reboot_after_test: | ||
| if reboot_after_test.name == item.name: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if reboot_after_test: | |
| if reboot_after_test.name == item.name: | |
| if reboot_after_test and reboot_after_test.name == item.name: |
Comment on lines
+176
to
+181
| to_reboot = [dev.reboot() for dev in devices] | ||
| up_ports = [dev.run_cmd('onlpd') for dev in devices] | ||
| await asyncio.gather(*to_reboot) | ||
| await asyncio.gather(*up_ports) |
Collaborator
There was a problem hiding this comment.
Suggested change
| to_reboot = [dev.reboot() for dev in devices] | |
| up_ports = [dev.run_cmd('onlpd') for dev in devices] | |
| await asyncio.gather(*to_reboot) | |
| await asyncio.gather(*up_ports) | |
| await asyncio.gather(*[dev.reboot() for dev in devices]) | |
| # https://github.com/dentproject/dentOS/issues/152#issuecomment-973264204 | |
| await asyncio.gather(*[dev.run_cmd('onlpd') for dev in devices]) |
Signed-off-by: Stepan Vovk <stepan.vovk@plvision.eu>
StepanVovkPLV
force-pushed
the
l1_tests_reboot_device
branch
from
2f19191 to
fe531c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective: if in collected tests we have at least one test_l1 we will sort the list with collected test items, and to the last test of the list(which will be last L1 test) we add additional fixture which will reboot device
def pytest_collection_modifyitems(session, config, items)will perform sorting of ALL the items based on the key providedpytest_collection_finish(session)hook we will select last test within current session and set the test where to add reboot fixtureasync def reboot_device(testbed)will perform reboot of the devicepytest_runtest_setup(item):we modify the last item in sortedsession.itemslist and addrebot_devicefixture