fix: ensuring a validation error is raised when output assignment will result in a LLVM error#1618
fix: ensuring a validation error is raised when output assignment will result in a LLVM error#1618Angus-Bethke-Bachmann wants to merge 10 commits intomasterfrom
Conversation
…l result in a LLVM error
| libFunction( | ||
| inVar1 := 0, | ||
| inVar2 := 0.0, | ||
| result => i1 |
There was a problem hiding this comment.
I feel like this should definitely work, no? This feels more like a codegen bug rather than a missing validation.
There was a problem hiding this comment.
Well in this case I compared to CODESYS, and they just flat-out refuse to type-cast:
There was a problem hiding this comment.
I believe codesys in general refuses implicit type casts, they're much stricter in that context than we are. Still, this feels like a codegen bug to me.
There was a problem hiding this comment.
After chatting with @ghaith yesterday, we decided to fix this with lowering. The necessary lowering has been added to perform the casting. In addition to this, I have removed the new error code, but it will still log the warning that implicit downcasting will occur.
…o anbt/PRG-3021
2 participants
Changed
Testing