Feature: Colocando minha solução#7
Open
AnthonyMRodrigues wants to merge 1 commit into
Open
Conversation
vitormattos
reviewed
Oct 19, 2018
|
|
||
| $firstValue = $argv[1]; | ||
| $secondValue = $argv[2]; | ||
| if ((is_null($firstValue) || $firstValue > 10.0) || (is_null($secondValue) || $secondValue > 10.0)) { |
Member
There was a problem hiding this comment.
Isto vai dar ruim se os valores informados forem string. Que tal usar filter_var com FILTER_VALIDATE_FLOAT ou algo em conjunto com FILTER_VALIDATE_INT?
Como a função tá forçando tipagem, isto também pode dar bem ruim se não for float, não?!
vitormattos
reviewed
Oct 19, 2018
| @@ -0,0 +1,37 @@ | |||
| <?php | |||
| /** | |||
| * Created by PhpStorm. | |||
Member
There was a problem hiding this comment.
O código todo tá com uma tabulação a mais no começo
vitormattos
reviewed
Oct 19, 2018
| return; | ||
| } | ||
|
|
||
| echo "Media = " . media($firstValue, $secondValue, 3.5, 7.5) . "\n"; No newline at end of file |
Member
There was a problem hiding this comment.
Atende por não termos ainda testes automatizados, mas na especificação tá em uppercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solução Media