Rename compartment-backed PySB mapping IDs to _c, fixes #113#115
Open
FFroehlich with Copilot wants to merge 6 commits into
Open
Rename compartment-backed PySB mapping IDs to _c, fixes #113#115FFroehlich with Copilot wants to merge 6 commits into
_c, fixes #113#115FFroehlich with Copilot wants to merge 6 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix invalid mapping table entries for PySB test cases
Fix PySB observable/mapping name conflicts in test cases 0010, 0011, 0013, 0017
Jul 4, 2026
Copilot
AI
changed the title
Fix PySB observable/mapping name conflicts in test cases 0010, 0011, 0013, 0017
Revert unnecessary DEFAULT_PYSB_FILE changes and remove generated local model files
Jul 4, 2026
Copilot
AI
changed the title
Revert unnecessary DEFAULT_PYSB_FILE changes and remove generated local model files
Rename compartment-backed PySB mapping IDs to Jul 4, 2026
_c and remove unintended model-file churn
_c and remove unintended model-file churn_c
FFroehlich
approved these changes
Jul 4, 2026
_c_c, fixes #133
_c, fixes #133_c, fixes #113
There was a problem hiding this comment.
Pull request overview
This pull request standardizes PEtab v2 PySB case mapping identifiers for compartment-scaled species by renaming A/B mapping IDs to A_c/B_c in the affected cases, and adds a regression test to ensure all v2 cases pass PEtab linting.
Changes:
- Renamed compartment-backed mapping IDs (
A→A_c,B→B_c) and updated condition references in PySB v2 cases 0010, 0011, 0013, and 0017. - Regenerated checked-in
_mapping.tsvand_conditions.tsvartifacts for those cases to match the updated source definitions. - Added a pytest regression test that lints all v2.0.0 cases for both SBML and PySB formats.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_general.py | Adds a regression test to lint all v2.0.0 cases (sbml + pysb). |
| petabtests/cases/v2.0.0/pysb/0010/0010.py | Updates condition keys and mapping IDs to use _c suffix. |
| petabtests/cases/v2.0.0/pysb/0010/_mapping.tsv | Renames mapping entity IDs to A_c/B_c. |
| petabtests/cases/v2.0.0/pysb/0010/_conditions.tsv | Updates condition target IDs to B_c. |
| petabtests/cases/v2.0.0/pysb/0011/0011.py | Updates condition keys and mapping IDs to use _c suffix. |
| petabtests/cases/v2.0.0/pysb/0011/_mapping.tsv | Renames mapping entity IDs to A_c/B_c. |
| petabtests/cases/v2.0.0/pysb/0011/_conditions.tsv | Updates condition target IDs to B_c. |
| petabtests/cases/v2.0.0/pysb/0013/0013.py | Updates condition keys and mapping IDs to use _c suffix. |
| petabtests/cases/v2.0.0/pysb/0013/_mapping.tsv | Renames mapping entity IDs to A_c/B_c. |
| petabtests/cases/v2.0.0/pysb/0013/_conditions.tsv | Updates condition target IDs to B_c. |
| petabtests/cases/v2.0.0/pysb/0017/0017.py | Updates condition keys and mapping IDs to use _c suffix. |
| petabtests/cases/v2.0.0/pysb/0017/_mapping.tsv | Renames mapping entity IDs to A_c/B_c. |
| petabtests/cases/v2.0.0/pysb/0017/_conditions.tsv | Updates condition target IDs to A_c/B_c. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the affected PySB v2 cases to use
_cfor mapping IDs that point to compartment-scaled species values.Mapping ID cleanup
0010,0011,0013, and0017:A→A_cB→B_cRegenerated checked-in case artifacts
_conditions.tsvand_mapping.tsvfiles for those four cases so the checked-in artifacts match the source definitions.Example of the intended rename: