Add test: Parameter in both observable formula and condition table#109
Open
sebapersson wants to merge 7 commits intoPEtab-dev:mainfrom
Open
Add test: Parameter in both observable formula and condition table#109sebapersson wants to merge 7 commits intoPEtab-dev:mainfrom
sebapersson wants to merge 7 commits intoPEtab-dev:mainfrom
Conversation
Contributor
Author
|
I suspect the CI errors might be due to the recent problems with PySB? |
dweindl
approved these changes
Feb 12, 2026
Member
dweindl
left a comment
dweindl
left a comment
There was a problem hiding this comment.
Thanks, looks good.
I suspect the CI errors might be due to the recent problems with PySB?
Yes :(
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Contributor
Author
|
As PySB has been fixed, the CI might work now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless I have interpreted it incorrectly, it is allowed to have a parameter which is estimated appearing in both the condition table (e.g., assigning an initial concentration), and in the observable formulas. This adds a test for this.
On a side note, if a tool passes this test, it has all the features needed for being able to, at the PEtab level, implement support for the multiple-shooting approach for parameter estimation .