Add test triggered at time-point without measurements#105
Merged
dweindl merged 8 commits intoPEtab-dev:mainfrom Dec 15, 2025
Merged
Add test triggered at time-point without measurements#105dweindl merged 8 commits intoPEtab-dev:mainfrom
dweindl merged 8 commits intoPEtab-dev:mainfrom
Conversation
Contributor
Author
|
I merged with main following #104 being merged, so this can now be merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the other test cases with non-initial PEtab conditions (
0016and0022), this test case includes a condition that is triggered at a time point without any measurement values. I have confirmed that the output matches what is computed by PEtab.jl.I believe this is important to test because many ODE solver libraries, unless configured otherwise, save model output immediately after an event/callback (e.g., diffrax in Jax). In this test, that behavior is not required, and if an importer always saves model output following a PEtab condition event, this test case may cause indexing issues when computing the model output.
Note, I added this as test-case 0028 so it can be merged following #104.