Skip to content

Add about dialog#171

Merged
dweindl merged 7 commits into
PEtab-dev:developfrom
dweindl:about
Sep 24, 2025
Merged

Add about dialog#171
dweindl merged 7 commits into
PEtab-dev:developfrom
dweindl:about

Conversation

@dweindl

@dweindl dweindl commented Sep 22, 2025

Copy link
Copy Markdown
Member

Closes #120.

@PaulJonasJost PaulJonasJost left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings are stored in works amazing 👍🏼

The about says version 0.0.1 for me for some reason?
And I don't find it in the Help -> About but Mac puts it automatically into the About Python. Seems to be a classical Mac thing again (just as quit)

@dweindl

dweindl commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

The about says version 0.0.1 for me for some reason?

Are you using and editable installation? Does it work after reinstalling the package?

And I don't find it in the Help -> About but Mac puts it automatically into the About Python. Seems to be a classical Mac thing again (just as quit)

For me (Ubuntu) it shows up as Help -> About. I am not familiar with how things are done on macos, whether it can or should be pushed into Help there.

@fbergmann

Copy link
Copy Markdown
Collaborator

I am not familiar with how things are done on macos, whether it can or should be pushed into Help there.

on macOS quit, About and Preferences should always be on the Application menu (where for now it still says python but really should say the name of the application.

@dweindl

dweindl commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

on macOS quit, About and Preferences should always be on the Application menu

Thanks.

(where for now it still says python but really should say the name of the application.

Now? (I don't have any macos.)

@PaulJonasJost

Copy link
Copy Markdown
Collaborator

Version shows now correct for me. It is now called python3.12. I tried renaming it to PEtabGUI before as well with no success. I think this is fine, as it is a byproduct of this not being an official app (as far as I understood). Would be fine to merge.

@dweindl

dweindl commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

Version shows now correct for me.

👍

It is now called python3.12. I tried renaming it to PEtabGUI before as well with no success. I think this is fine, as it is a byproduct of this not being an official app (as far as I understood). Would be fine to merge.

@fbergmann Any ideas on how to change the application name on macos?

@dweindl

dweindl commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

Any idea whether this can be done for Python package entrypoints? https://stackoverflow.com/questions/16427221/how-do-i-change-my-qt-app-name-on-the-mac-os-x-system-menu

(Without pyinstaller or the like)

@fbergmann

Copy link
Copy Markdown
Collaborator

@dweindl I've tried it on a mac now, and it does work, though it requires the pyobjc package, once installed it works with:

--- a/src/petab_gui/app.py
+++ b/src/petab_gui/app.py
@@ -132,6 +132,14 @@ def main():
     )
     args = parser.parse_args()
 
+    if sys.platform == "darwin":
+        from Foundation import NSBundle
+        bundle = NSBundle.mainBundle()
+        info = bundle.localizedInfoDictionary() or bundle.infoDictionary()
+        info["CFBundleName"] = "PEtab GUI"
+
     app = PEtabGuiApp(args.petab_yaml)
     sys.exit(app.exec())

@dweindl

dweindl commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

@dweindl I've tried it on a mac now, and it does work, though it requires the pyobjc package, once installed it works with: [...]

Cool, thanks. I added that. Someone please confirm that it works (including installing the dependencies).

@fbergmann

Copy link
Copy Markdown
Collaborator

@dweindl i can confirm that it does work on macos as expected

@dweindl dweindl merged commit e6b622d into PEtab-dev:develop Sep 24, 2025
4 checks passed
@dweindl dweindl deleted the about branch September 24, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add About dialog

3 participants