Skip to content

Visualization Lint#169

Merged
PaulJonasJost merged 3 commits into
developfrom
visualization_table_error
Sep 24, 2025
Merged

Visualization Lint#169
PaulJonasJost merged 3 commits into
developfrom
visualization_table_error

Conversation

@PaulJonasJost

@PaulJonasJost PaulJonasJost commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator
  • Fix not capturing error from visualization lint
  • enable linting of visualization table

Closes #134

- enable linting of visualization table

Close #134

@dweindl dweindl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves things a bit. Now I see

[2025-09-22 20:06:16] PEtab linter failed at (0, xValues): validate_visualization_df
[2025-09-22 20:06:44] PEtab linter failed at (0, yValues): validate_visualization_df

which points at the right cell but I still don't see the full error message.

# Conflicts:
#	src/petab_gui/controllers/table_controllers.py

@dweindl dweindl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works now!

@PaulJonasJost PaulJonasJost merged commit 67e7aa2 into develop Sep 24, 2025
6 checks passed
@PaulJonasJost PaulJonasJost deleted the visualization_table_error branch September 24, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visualization table error not captured

2 participants