propose diff folder names #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeerHerholz
approved these changes
Jan 26, 2024
Collaborator
PeerHerholz
left a comment
PeerHerholz
left a comment
There was a problem hiding this comment.
No preference on my end and thus LGTM.
more likely use case
Collaborator
Author
|
since a set of histological images or here changed to tumour is not derived from a BIDS dataset per see, I actually think it would be share as raw, see commit 3 -- as since I was at it, commit 4, all of those subject atlases will have the same labels |
Collaborator
|
Cool, thanks. However, I don't really understand the updated case 3, sorry. Wouldn't the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) since all other bids examples are within dataset I do not think this is necessary to have that here
(2) in an effort to have examples tightly coupled to the spec, added cases 1, 2, 3