events page updated #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goyalritesh21
requested changes
May 12, 2020
Collaborator
goyalritesh21
left a comment
goyalritesh21
left a comment
There was a problem hiding this comment.
Make the suggested chnages
| "react-router-dom": "^5.1.2", | ||
| "react-scripts": "3.4.1", | ||
| "react-use": "^14.2.0", | ||
| "@material-ui/core": "latest" |
Collaborator
There was a problem hiding this comment.
use this version of material-ui/core
| "version": "0.1.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "@material-ui/core": "^4.9.13", |
Collaborator
There was a problem hiding this comment.
this version should not be used
| @@ -1,9 +1,96 @@ | |||
| import React from 'react' | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
Collaborator
There was a problem hiding this comment.
Add prop-types as a dependency in package.json
Comment on lines
+86
to
+92
| <Showcase/> | ||
| </TabPanel> | ||
| <TabPanel value={value} index={1}> | ||
| <Showcase/> | ||
| </TabPanel> | ||
| <TabPanel value={value} index={2}> | ||
| <Showcase/> |
Collaborator
There was a problem hiding this comment.
Pass cardData as a prop to component
| <Tab label="Past Events" {...a11yProps(2)} /> | ||
| </Tabs> | ||
| </AppBar> | ||
| <TabPanel value={value} index={0}> |
Collaborator
There was a problem hiding this comment.
Each card has an unexpected background. Check that and correct the styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.