Skip to content

feat: bump mesa loader windows to 26.0.4#2847

Open
CiiLu wants to merge 2 commits into
devfrom
feat/mesaloader
Open

feat: bump mesa loader windows to 26.0.4#2847
CiiLu wants to merge 2 commits into
devfrom
feat/mesaloader

Conversation

@CiiLu
Copy link
Copy Markdown
Member

@CiiLu CiiLu commented May 17, 2026

Summary by Sourcery

增强内容:

  • 在 Minecraft 启动和库设置代码中,将 Mesa 加载器的 Windows 版本引用从 25.3.5 更新为 26.0.4。
Original summary in English

Summary by Sourcery

Enhancements:

  • Bump the Mesa loader Windows version reference from 25.3.5 to 26.0.4 across Minecraft launch and library setup code.

@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels May 17, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 17, 2026

审查者指南(在小型 PR 上折叠显示)

审查者指南

将用于渲染相关启动参数和库下载的硬编码 Mesa loader Windows 版本,从 25.3.5 更新为 26.0.4,覆盖旧/新 JVM 启动路径以及实例库解析逻辑。

更新后 Mesa loader Windows 版本使用流程图

flowchart TD
    A[ModLaunch.McLaunchArgumentsJvmOld]
    B[ModLaunch.McLaunchArgumentsJvmNew]
    C[ModMinecraft.McLibNetFilesFromInstance]
    V[MesaLoaderWindowsVersion 26.0.4]
    F[MesaLoaderWindowsTargetFile Loader.jar]

    V --> F
    A --> V
    B --> V
    C --> V
    A --> F
    B --> F
    C --> F
Loading

文件级变更

变更 详情 文件
更新 JVM 启动参数构造中使用的 Mesa loader Windows 版本常量。
  • 在旧 JVM 启动参数构造器中,将 MesaLoaderWindowsVersion 字符串从 25.3.5 修改为 26.0.4。
  • 在新 JVM 启动参数构造器中,将 MesaLoaderWindowsVersion 字符串从 25.3.5 修改为 26.0.4。
Plain Craft Launcher 2/Modules/Minecraft/ModLaunch.cs
更新渲染器相关库下载解析中使用的 Mesa loader Windows 版本常量。
  • 在计算实例库下载所需的 mesa-loader-windows Loader.jar 路径时,将 mesaLoaderWindowsVersion 字符串从 25.3.5 修改为 26.0.4。
Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.cs

提示与命令

与 Sourcery 交互

  • 触发新的审查: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub issue: 在某条审查评论下回复,要求 Sourcery 从该评论创建一个 issue。你也可以在审查评论下回复 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文任意位置写上 @sourcery-ai summary,即可在你想要的位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审查者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审查者指南。
  • 一次性解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 一次性撤销所有 Sourcery 审查: 在 pull request 中评论 @sourcery-ai dismiss,即可撤销所有现有的 Sourcery 审查。如果你想从头开始一次全新的审查,这尤其有用——别忘了再评论 @sourcery-ai review 来触发新审查!

自定义你的使用体验

访问你的 仪表盘 来:

  • 启用或禁用审查功能,例如 Sourcery 自动生成的 pull request 摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the hardcoded Mesa loader Windows version used for rendering-related launch arguments and library downloads from 25.3.5 to 26.0.4 across both old/new JVM launch paths and instance library resolution.

Flow diagram for updated Mesa loader Windows version usage

flowchart TD
    A[ModLaunch.McLaunchArgumentsJvmOld]
    B[ModLaunch.McLaunchArgumentsJvmNew]
    C[ModMinecraft.McLibNetFilesFromInstance]
    V[MesaLoaderWindowsVersion 26.0.4]
    F[MesaLoaderWindowsTargetFile Loader.jar]

    V --> F
    A --> V
    B --> V
    C --> V
    A --> F
    B --> F
    C --> F
Loading

File-Level Changes

Change Details Files
Update Mesa loader Windows version constant used in JVM launch argument construction.
  • Change the MesaLoaderWindowsVersion string from 25.3.5 to 26.0.4 in the old JVM launch argument builder.
  • Change the MesaLoaderWindowsVersion string from 25.3.5 to 26.0.4 in the new JVM launch argument builder.
Plain Craft Launcher 2/Modules/Minecraft/ModLaunch.cs
Update Mesa loader Windows version constant used in renderer-related library download resolution.
  • Change the mesaLoaderWindowsVersion string from 25.3.5 to 26.0.4 when computing the mesa-loader-windows Loader.jar path for instance library downloads.
Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里给出了一些整体性的反馈:

  • Mesa loader 的 Windows 版本字符串在多个方法中被重复使用;建议将其提取为单一的常量或配置值,以避免未来升级时出现不一致。
给 AI 代理的提示
Please address the comments from this code review:

## Overall Comments
- The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.

Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English

Hey - I've left some high level feedback:

  • The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zkitefly
Copy link
Copy Markdown
Contributor

zkitefly commented May 17, 2026

可以顺便支持更多渲染器选项

参考 https://github.com/HMCL-dev/mesa-loader-windows/blob/fc8a412503ad47e989fd8dfc673b6d501ac8be9e/src/main/java/org/glavo/mesa/Loader.java#L73-L96

新增了 lavapipedzn

@pcl-ce-automation pcl-ce-automation Bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels May 17, 2026
@zkitefly
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@LinQingYuu LinQingYuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use public const string

@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS PR 大小评估:微型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants