feat: bump mesa loader windows to 26.0.4#2847
Open
CiiLu wants to merge 2 commits into
Open
Conversation
审查者指南(在小型 PR 上折叠显示)审查者指南将用于渲染相关启动参数和库下载的硬编码 Mesa loader Windows 版本,从 25.3.5 更新为 26.0.4,覆盖旧/新 JVM 启动路径以及实例库解析逻辑。 更新后 Mesa loader Windows 版本使用流程图flowchart TD
A[ModLaunch.McLaunchArgumentsJvmOld]
B[ModLaunch.McLaunchArgumentsJvmNew]
C[ModMinecraft.McLibNetFilesFromInstance]
V[MesaLoaderWindowsVersion 26.0.4]
F[MesaLoaderWindowsTargetFile Loader.jar]
V --> F
A --> V
B --> V
C --> V
A --> F
B --> F
C --> F
文件级变更
提示与命令与 Sourcery 交互
自定义你的使用体验访问你的 仪表盘 来:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the hardcoded Mesa loader Windows version used for rendering-related launch arguments and library downloads from 25.3.5 to 26.0.4 across both old/new JVM launch paths and instance library resolution. Flow diagram for updated Mesa loader Windows version usageflowchart TD
A[ModLaunch.McLaunchArgumentsJvmOld]
B[ModLaunch.McLaunchArgumentsJvmNew]
C[ModMinecraft.McLibNetFilesFromInstance]
V[MesaLoaderWindowsVersion 26.0.4]
F[MesaLoaderWindowsTargetFile Loader.jar]
V --> F
A --> V
B --> V
C --> V
A --> F
B --> F
C --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈:
- Mesa loader 的 Windows 版本字符串在多个方法中被重复使用;建议将其提取为单一的常量或配置值,以避免未来升级时出现不一致。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Mesa loader Windows version string is duplicated in multiple methods; consider extracting it into a single constant or configuration value to avoid inconsistencies on future bumps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Pigeon0v0
approved these changes
May 17, 2026
LuLu-ling
approved these changes
May 17, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
增强内容:
Original summary in English
Summary by Sourcery
Enhancements: