Conversation
flekschas
reviewed
Sep 23, 2023
Comment on lines
+61
to
+62
| left_embedding: Embedding | pd.DataFrame, | ||
| right_embedding: Embedding | pd.DataFrame, |
Contributor
There was a problem hiding this comment.
Is this backwards compatible with Python versions before 11?
Contributor
Author
There was a problem hiding this comment.
Yes, the top of the file uses:
from __future__ import annotationsWhich tells Python to treat everything after the : in types as comments. We only use for static type checking, so this allows us to use modern syntax. If we needed to inspect the types at runtime (e.g., using pydantic in this file), we'd want to avoid using __future__ annotations imports and find a typing syntax that is backward compatbile.
manzt
force-pushed
the
main
branch
5 times, most recently
from
2406222 to
acad765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now you need to create an
Embeddings from a dataframe to use theEmbeddingComparisonWidget. This PR lets you pass in dataframes as well, and will select thex,y,label,robust(option) columns to create theEmbeddingobject.