feat: fashion mnist and non robustness filtering#41
Open
flekschas-ozette wants to merge 2 commits intomainfrom
Open
feat: fashion mnist and non robustness filtering#41flekschas-ozette wants to merge 2 commits intomainfrom
flekschas-ozette wants to merge 2 commits intomainfrom
Conversation
Also check that `self._data[_LABEL_COLUMN][0]` is a string before checking for `+`
Contributor
|
@manzt shall we still merge this? The string check for checking whether the label is a marker could still be useful I think |
Contributor
|
Good question! I think the changes to the |
Contributor
|
Actually, wasn't this implemented in #43? |
Contributor
Author
|
Not this part: We currently assume that the label column is a string but it doesn't have to be. Ints can also define categories (like in the clustering case where the labels are just cluster ints) I think having this notebook could be useful in general? Like when someone finds this tool but doesn't have labels yet? What do you think? |
2406222 to
acad765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one small bug (when the categorical labels are not of type string) and filters out non-robust points from the metric scatter. The later allows the user to keep non-robust points in the categorical scatter (drawn as dark gray points) without being visually impacted by their metric value.
Most importantly, this PR adds a useful for how to compare different embedding methods (with and without existing label information) using Fashion MNIST data.