oopsy: Windurst Third Walk#1062
Open
JLGarber wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
💬ko
💬cn
💬de
💬ja
💬fr
oopsy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in-game. Not everything happened the test run I did, but of the mistakes I saw, everything got called. Probably worth having a few people run this themselves to verify some of the less common ones like Aero Dynamics failures, but it did look relatively clean when I ran tonight.
A thing that occurred to me as I was assembling this is that we might want to restrict use of
shareWarnfor "one person without a spread stood on a person with" to 8-player content or fewer, or to cases where any overlap is explicitly wrong. In 24-player content it can get very noisy with safe overlaps that are fully normal and expected, which in turn can obscure the "real" situations where two spread indicators get overlapped.