Skip to content

A different branch with the bat implementation #97

Open
ResendeTech wants to merge 2 commits intomainfrom
Bat-implementation
Open

A different branch with the bat implementation #97
ResendeTech wants to merge 2 commits intomainfrom
Bat-implementation

Conversation

@ResendeTech
Copy link
Member

@ResendeTech ResendeTech commented Apr 25, 2025

User description

I don't understand why there are so many changed files, imports or something


PR Type

Enhancement


Description

  • Added unique Godot UID files for scripts and scenes

  • Updated scene files to reference new UID-based resources

  • Improved fuel slider integration in player scene

  • Updated project settings and environment references


Changes walkthrough 📝

Relevant files
Enhancement
28 files
playlist.gd.uid
Add UID file for playlist.gd script                                           
+1/-0     
track.gd.uid
Add UID file for track.gd script                                                 
+1/-0     
background_music_player.tscn
Update script references to use UID-based resources           
+3/-3     
background_music_player.gd.uid
Add UID file for background_music_player.gd script             
+1/-0     
better bat.tscn
Update scene UID for better bat scene                                       
+1/-1     
landing_pad.gd.uid
Add UID file for landing_pad.gd script                                     
+1/-0     
level_2.5.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_2.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_3.5.tscn
Update script and refueling_pad references to UID-based resources
+2/-2     
level_3.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_4.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_5.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_7.tscn
Update script reference to UID-based landing_pad.gd           
+1/-2     
level_8.tscn
Update script and cave_2 scene references to UID-based resources
+2/-2     
level_9.tscn
Update script and cave_2 scene references to UID-based resources
+2/-2     
refueling_pad.gd.uid
Add UID file for refueling_pad.gd script                                 
+1/-0     
refueling_pad.tscn
Update scene UID and script reference to UID-based resource
+2/-2     
camera_mount.gd.uid
Add UID file for camera_mount.gd script                                   
+1/-0     
fuel_slider.tscn
Update scene UID and script reference to UID-based resource
+2/-2     
main_menu.tscn
Update script reference to UID-based main_menu.gd               
+1/-1     
moving_hazard.gd.uid
Add UID file for moving_hazard.gd script                                 
+1/-0     
moving_hazard.tscn
Update script reference to UID-based moving_hazard.gd       
+1/-1     
landing_controller.gd.uid
Add UID file for landing_controller.gd script                       
+1/-0     
player.tscn
Integrate new fuel slider and update resource references to UIDs
+10/-8   
stability_controller.gd.uid
Add UID file for stability_controller.gd script                   
+1/-0     
sliding_door.gd.uid
Add UID file for sliding_door.gd script                                   
+1/-0     
sliding_door.tscn
Update script reference to UID-based sliding_door.gd         
+1/-1     
trigger_pad.gd.uid
Add UID file for trigger_pad.gd script                                     
+1/-0     
Configuration changes
1 files
project.godot
Update project config features version                                     
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    UI Positioning

    The fuel slider has been repositioned with new properties. Verify that the new position and visibility settings work correctly across different screen resolutions.

    [node name="FuelSlider" parent="Fuel" instance=ExtResource("5_lgqa7")]
    light_mask = 512
    visibility_layer = 128
    z_as_relative = false
    offset_top = 445.0
    offset_right = 142.0
    offset_bottom = 686.0
    Environment Reference

    The environment reference has changed from 'scenes/environment_test.tscn' to 'environments/cave_2.tscn'. Ensure this doesn't break level functionality.

    [ext_resource type="PackedScene" uid="uid://it6majhd2sqd" path="res://environments/cave_2.tscn" id="3_he5db"]
    [ext_resource type="PackedScene" uid="uid://bexur4xjjutc" path="res://scenes/moving_hazard.tscn" id="4_06lua"]

    @qodo-code-review
    Copy link

    qodo-code-review bot commented Apr 25, 2025

    PR Code Suggestions ✨

    Latest suggestions up to 68529af

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Resolve merge conflict

    Resolve the Git merge conflict in the refueling_pad.tscn file. You need to
    choose one version of the script path and remove the conflict markers.

    scenes/refueling_pad.tscn [3-7]

    -<<<<<<< HEAD:refueling_pad.tscn
    -[ext_resource type="Script" uid="uid://dcsta8rmoe340" path="res://refueling_pad.gd" id="1_6wxl3"]
    -=======
     [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]
    ->>>>>>> origin/main:scenes/refueling_pad.tscn

    [Suggestion has been applied]

    Suggestion importance[1-10]: 10

    __

    Why: This suggestion correctly identifies an unresolved Git merge conflict in the code, which would prevent the game from running properly. Resolving this conflict is critical for the functionality of the project, and the suggestion correctly chooses the version from the main branch.

    High
    • More

    Previous suggestions

    ✅ Suggestions up to commit 8eab71d
    CategorySuggestion                                                                                                                                    Impact
    General
    UI component path changed
    Suggestion Impact:The commit confirms the removal of the FuelSlider node from its original location. The FuelSlider and its parent Sprite2D were removed, and instead a new HUD component was added, which likely contains the fuel slider functionality in a new location.

    code diff:

    -[ext_resource type="PackedScene" uid="uid://bt0f8rckpnlhi" path="res://scenes/fuel_slider.tscn" id="5_lgqa7"]
    -[ext_resource type="Texture2D" uid="uid://bwn182o341f5n" path="res://assets/sprites/Fuel gauge speedometer.png" id="5_sbef4"]
     [ext_resource type="Script" uid="uid://d20lgmwr5ukoh" path="res://scenes/player/stability_controller.gd" id="6_jxs5u"]
    -[ext_resource type="PackedScene" uid="uid://b2rt1lvgtdcsq" path="res://e_button.tscn" id="7_0w6d2"]
     [ext_resource type="Script" uid="uid://e56syxi527h2" path="res://scenes/player/landing_controller.gd" id="7_p66tl"]
     [ext_resource type="Material" uid="uid://yq2ywrvw8k7y" path="res://materials/ship_blue.tres" id="8_5sakl"]
    +[ext_resource type="PackedScene" uid="uid://c1v1ppm8x01cy" path="res://scenes/ui/hud.tscn" id="8_gq37x"]
     [ext_resource type="Material" uid="uid://6fwd7r8tmf8v" path="res://particles/explosion_particles.tres" id="10_xw84m"]
    -[ext_resource type="Script" uid="uid://xoexbbmgrf0d" path="res://scenes/player/effects_controller.gd" id="11_smcew"]
    +[ext_resource type="Script" uid="uid://bgjutt58yio44" path="res://scenes/player/effects_controller.gd" id="11_smcew"]
     [ext_resource type="Material" uid="uid://xrb2i7caokn4" path="res://particles/success_particles.tres" id="12_msahl"]
     [ext_resource type="Material" uid="uid://b8nvx6ca73y1r" path="res://materials/success_material.tres" id="13_x3ewv"]
     [ext_resource type="PackedScene" uid="uid://buxj68c16odaq" path="res://assets/models/rocket/scene.gltf" id="17_3kkwo"]
    +[ext_resource type="PackedScene" uid="uid://c1keu360hjpld" path="res://scenes/ui/pause_menu.tscn" id="18_w1p2d"]
     
     [sub_resource type="CylinderShape3D" id="CylinderShape3D_sg736"]
    -height = 1.2
    +height = 1.5
     
     [sub_resource type="CylinderShape3D" id="CylinderShape3D_bc2uk"]
     height = 0.71
    @@ -108,20 +107,6 @@
     [node name="Fuel" type="Node3D" parent="."]
     script = ExtResource("4_qtt7p")
     
    -[node name="Sprite2D" type="Sprite2D" parent="Fuel"]
    -z_index = 900
    -position = Vector2(107, 685)
    -scale = Vector2(5, 5)
    -texture = ExtResource("5_sbef4")
    -
    -[node name="FuelSlider" parent="Fuel" instance=ExtResource("5_lgqa7")]
    -light_mask = 512
    -visibility_layer = 128
    -z_as_relative = false
    -offset_top = 445.0
    -offset_right = 142.0
    -offset_bottom = 686.0

    The FuelSlider node has been moved from scenes/ui/fuel_slider.tscn to a
    different path and its properties have changed significantly. Verify that the
    new slider works correctly with the fuel system and displays properly with the
    new position values.

    scenes/player/player.tscn [117-123]

    +[node name="FuelSlider" parent="Fuel" instance=ExtResource("5_lgqa7")]
    +light_mask = 512
    +visibility_layer = 128
    +z_as_relative = false
    +offset_top = 445.0
    +offset_right = 142.0
    +offset_bottom = 686.0
     
    -

    [Suggestion has been applied]

    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies a significant change in the fuel slider component's path and properties. This is an important observation as it could affect the game's UI functionality and fuel system.

    Medium
    Godot version upgrade caution

    The project is being upgraded from Godot 4.3 to 4.4. This version change might
    introduce compatibility issues or require additional project adjustments. Ensure
    all scenes and scripts are compatible with Godot 4.4.

    project.godot [15]

    +config/features=PackedStringArray("4.4", "Forward Plus")
     
    -
    Suggestion importance[1-10]: 7

    __

    Why: This is a valid concern as upgrading from Godot 4.3 to 4.4 could introduce compatibility issues. The suggestion correctly identifies a potential risk that might require project-wide adjustments.

    Medium
    Environment scene path changed

    The environment scene path has been changed from
    res://scenes/environment_test.tscn to res://environments/cave_2.tscn. Ensure
    that the new cave environment has all the necessary elements that were present
    in the original test environment to maintain gameplay functionality.

    levels/level_8.tscn [5]

    +[ext_resource type="PackedScene" uid="uid://it6majhd2sqd" path="res://environments/cave_2.tscn" id="3_he5db"]
     
    -
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion accurately identifies a change in the environment scene path that could impact gameplay. This is important to verify as the new environment must maintain all necessary gameplay elements.

    Medium

    @ResendeTech ResendeTech requested a review from brylie April 25, 2025 11:16
    Comment on lines +4 to +7
    <<<<<<< HEAD:scenes/fuel_slider.tscn
    [ext_resource type="Script" uid="uid://nr0q7iu61suy" path="res://scenes/fuel_bar.gd" id="2_q6t1k"]
    =======
    >>>>>>> origin/main:scenes/ui/fuel_slider.tscn
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We should remove these Git merge conflict markers:

    Suggested change
    <<<<<<< HEAD:scenes/fuel_slider.tscn
    [ext_resource type="Script" uid="uid://nr0q7iu61suy" path="res://scenes/fuel_bar.gd" id="2_q6t1k"]
    =======
    >>>>>>> origin/main:scenes/ui/fuel_slider.tscn
    [ext_resource type="Script" uid="uid://nr0q7iu61suy" path="res://scenes/fuel_bar.gd" id="2_q6t1k"]

    Comment on lines +3 to +7
    <<<<<<< HEAD:refueling_pad.tscn
    [ext_resource type="Script" uid="uid://dcsta8rmoe340" path="res://refueling_pad.gd" id="1_6wxl3"]
    =======
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]
    >>>>>>> origin/main:scenes/refueling_pad.tscn
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This contains merge conflict makers:

    Suggested change
    <<<<<<< HEAD:refueling_pad.tscn
    [ext_resource type="Script" uid="uid://dcsta8rmoe340" path="res://refueling_pad.gd" id="1_6wxl3"]
    =======
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]
    >>>>>>> origin/main:scenes/refueling_pad.tscn
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]

    Copy link
    Member

    @brylie brylie left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We can't merge this with the merge conflict markers still in the code, since Godot won't know how to parse those files.

    Comment on lines +3 to +7
    <<<<<<< HEAD:refueling_pad.tscn
    [ext_resource type="Script" uid="uid://dcsta8rmoe340" path="res://refueling_pad.gd" id="1_6wxl3"]
    =======
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]
    >>>>>>> origin/main:scenes/refueling_pad.tscn

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggestion: Resolve merge conflict

    Suggested change
    <<<<<<< HEAD:refueling_pad.tscn
    [ext_resource type="Script" uid="uid://dcsta8rmoe340" path="res://refueling_pad.gd" id="1_6wxl3"]
    =======
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]
    >>>>>>> origin/main:scenes/refueling_pad.tscn
    [ext_resource type="Script" uid="uid://df7nhc0md14xw" path="res://scenes/refueling_pad.gd" id="1_6wxl3"]

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants