Skip to content

ROU-12485: add fontAwesome as fallback#1111

Merged
BenOsodrac merged 1 commit intodevfrom
ROU-12485-v2
Feb 25, 2026
Merged

ROU-12485: add fontAwesome as fallback#1111
BenOsodrac merged 1 commit intodevfrom
ROU-12485-v2

Conversation

@BenOsodrac
Copy link
Contributor

This pull request updates the icon library handling and styling for dropdown components, standardizing icon usage and improving fallback behavior. The main focus is on switching the default icon library to FontAwesome, updating icon variables, and refining how icons are rendered in dropdowns.

Icon library and variable updates:

  • Changed the default icon library from Phosphor to FontAwesome by updating the CSS variable definitions in src/scss/01-foundations/_icon-library-odc.scss. All icon variables now use FontAwesome codes as the fallback, with Phosphor as an alternative.
  • Updated the logic in IconLibrary.ts so that if the new icon library is an empty string, no changes are made, preventing unnecessary updates.

Dropdown styling improvements:

  • Moved the caret icon styling for dropdown selected values from the component-specific SCSS (_dropdown-serverside.scss) to the foundational icon library SCSS (_icon-library-o11.scss), ensuring consistent icon rendering and font usage.
  • Removed direct FontAwesome icon and font styling from the dropdown's SCSS, relying instead on the global icon library variables and styles for consistency.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@BenOsodrac BenOsodrac requested a review from a team as a code owner February 25, 2026 13:49
@BenOsodrac BenOsodrac added bug Something isn't working chore labels Feb 25, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@BenOsodrac BenOsodrac merged commit b01b406 into dev Feb 25, 2026
14 of 19 checks passed
@BenOsodrac BenOsodrac deleted the ROU-12485-v2 branch February 25, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants