Skip to content

ROU-12485: add icon library support on CSS use-cases#1109

Merged
BenOsodrac merged 7 commits intodevfrom
ROU-12485
Feb 25, 2026
Merged

ROU-12485: add icon library support on CSS use-cases#1109
BenOsodrac merged 7 commits intodevfrom
ROU-12485

Conversation

@BenOsodrac
Copy link
Contributor

This pull request reorganizes and centralizes the handling of icon-related styles and markup across the SCSS codebase. The main change is the introduction of a new icon-library-odc foundation file, which consolidates icon definitions and related styles previously scattered throughout the project. This results in a cleaner, more maintainable structure, and removes redundant or duplicated icon CSS from individual widget and pattern files.

Key changes include:

Icon Library Centralization:

  • Added a new file 01-foundations/icon-library-odc containing all icon-related styles, including FontAwesome icon usage for accordions, search, submenu arrows, dropdowns, and sortable table icons. This file now serves as the single source of truth for icon styles.
  • Updated ODC SCSS entrypoints (gulp/ProjectSpecs/ScssStructure/Root.js, src/scss/ODC.OutSystemsUI.scss) to include the new icon library section and import the file, ensuring icons are available throughout the ODC platform. [1] [2] [3] [4]

Widget and Pattern SCSS Cleanup:

  • Removed redundant or now-centralized icon CSS from widget and pattern SCSS files, such as accordion caret, search input backgrounds, submenu header icons, dropdown arrows, and sortable table icons. These have all been moved to the new icon library file. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]

Project Structure and Build Updates:

  • Updated build configuration and project spec files to reference the new icon library and removed the now-obsolete table-sortable-icon widget section. [1] [2] [3]

These changes improve maintainability by ensuring all icon styles are defined in a single location, reducing duplication and making it easier to update or extend icon usage in the future.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@BenOsodrac BenOsodrac requested a review from a team as a code owner February 24, 2026 18:03
@BenOsodrac BenOsodrac added enhancement New feature or request chore labels Feb 24, 2026
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just have found something that we may want to delete.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@BenOsodrac BenOsodrac merged commit f4b51b8 into dev Feb 25, 2026
12 of 18 checks passed
@BenOsodrac BenOsodrac deleted the ROU-12485 branch February 25, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants