Fix/Persist inappbrowser webview across different calls#32
Open
nflsilva wants to merge 2 commits intooutsystemsfrom
Open
Fix/Persist inappbrowser webview across different calls#32nflsilva wants to merge 2 commits intooutsystemsfrom
nflsilva wants to merge 2 commits intooutsystemsfrom
Conversation
andregrillo
approved these changes
Sep 14, 2021
alexgerardojacinto
approved these changes
Nov 10, 2022
|
Hello, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
A particular customer requested support because they were not able to open a specific webpage using the InAppBrowser.
After some investigation, we concluded that this was an issue regarding the WebView session being destroyed on different calls to the Cordova action.
Description
We changed the code so only 1 WebView is created during all plugin lifetime. We keep in memory a reference the the same webview.
Testing
These changes were tested with MABS7
Checklist
(platform)if this change only applies to one platform (e.g.(android))