Mandatory Multisig#30
Open
thelink2012 wants to merge 1 commit intoOutCast3k:masterfrom
thelink2012:mandatory-multisig
Open
Mandatory Multisig#30thelink2012 wants to merge 1 commit intoOutCast3k:masterfrom thelink2012:mandatory-multisig
thelink2012 wants to merge 1 commit intoOutCast3k:masterfrom
thelink2012:mandatory-multisig
Conversation
Owner
|
Hmmm. This is really cool. I will review your code and look into the issue with fixing the backend so it accepts the signed transaction and then accept your request to merge. Nice work. |
|
Agreed, very cool, will be reviewing and testing this tonight for PiggyCoinb.in :) |
|
@OutCast3k Coinb.in itself is really awesome and desperately needed if people are going to trade safely in a trustless manner. I was thinking a more general construction with logical and/or in it might be good but thelink2012 nailed it by designing this as multisig with a mandatory component which is the only use-case I need supported and was probably a lot more straightforward to implement. Looking forward to see this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Issue: Broadcasting using coinb.in doesn't work properly for these transactions, using blockchain.info though goes just fine. So there's something that should be fixed on the backend I guess.