Open
Conversation
…th the handshake failing.
…sion added all SSL stuff between defines. In order to enable SSL add -DASYNC_TCP_SSL_ENABLED to your build flags.
… released version of arduino-esp32...
…er library is also used.
* Fix assertion errors * Add state check * replace tabs with spaces
* Tidy up and fix some edge cases. * Make sure we always release a closed_slot.
* Fix LoadProhibited (me-no-dev#73) * Use sizeof instead of strlen for const char[] * Add Kconfig option to control ASYNC_TCP_SSL_ENABLED * Optionally include ssl header files * Add null check for psk_ident and pskey * Do not default to PSK when root_ca is not explcitly set. tcp_ssl_new_client() has a case to handle this. * Move psk null checks to top of function, remove unneeded include, syntax cleanup. Authored-by: Bob <bob.mooij@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tve has created a branch of AsyncTCP which supports client-side TLS. This is useful for ESPHome if you want to use MQTT over TLS.
I would like to suggest that it be added to ESPHome's AsyncTCP to enable ESPHome experimental support for TLS which will need to be explicitly enabled by a user in the YAML.
I have been using ESPHome with this branch of AsyncTCP for a while now and I haven't observed any problems.
There is a discussion about this branch here: me-no-dev#48