Changed the PropTypes from React to prop-types #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienthiery
suggested changes
Jan 22, 2018
Contributor
adrienthiery
left a comment
adrienthiery
left a comment
There was a problem hiding this comment.
Thanks again for contributing.
Just a few comments (similar to the ones on the button) and I'll be able to merge :)
| label: React.PropTypes.string, | ||
| mode: React.PropTypes.oneOf([ | ||
| iosDoneButtonText: PropTypes.string, | ||
| iosDoneButtonStyle: PropTypes.containerStyle, |
Contributor
There was a problem hiding this comment.
I'm not sure this would work, I doubt the React PropTypes have a containerStyle type.
I think the Button.propTypes should stay that way, as they are using react-native-osd-simple-button's propTypes
| View, | ||
| } from 'react-native'; | ||
| import Button from 'react-native-osd-simple-button'; | ||
| import PropTypes from 'prop-types' |
Contributor
There was a problem hiding this comment.
Would you mind adding a ; at the end of the line to keep up with linting rules please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React package don't have proptypes property anymore, instead it is in another package, "prop-types". I added the dependency and used it.
Also, I changed the dependency to react-native-osd-simple-button to my fork of it (did the same with proptypes in that repo too)
Fixing #6