docs(agents): remove stale briefcase guidance

.github/copilot-instructions.md

@@ -1,134 +1,52 @@
 # AccessiWeather AI Coding Agent Instructions
 
-## Project Overview
-AccessiWeather is a cross-platform, accessible desktop weather application built with BeeWare/Toga (v0.9+) framework and Briefcase for packaging. The app targets Python 3.10+ (3.12 recommended) and prioritizes screen reader accessibility, multi-source weather data, and a simple architecture.
+AccessiWeather is a cross-platform accessible desktop weather app built with Python and wxPython. It targets Python 3.11+ and uses Nuitka packaging scripts for desktop artifacts.
 
-## Core Architecture
+## Architecture
 
-### Weather Data Sources (Multi-Source Strategy)
-- **Primary**: NWS API (weather.gov) for US locations - most accurate, no API key required
-- **Fallback**: Open-Meteo for NWS failures or international locations - free, no API key
-- **Enrichment**: Visual Crossing for enhanced alert data - requires API key, optional
-- **Data Flow**: `WeatherClient` coordinates sources, `WeatherDataCache` caches responses (5-minute default)
-- **Alert System**: `AlertManager` + `AlertNotificationSystem` handle notifications with rate limiting and severity filtering
+- Entry point: `src/accessiweather/main.py`
+- App orchestration: `src/accessiweather/app.py`
+- UI: `src/accessiweather/ui/`
+- Config: `src/accessiweather/config/`
+- API clients: `src/accessiweather/api/`
+- Weather orchestration: `src/accessiweather/weather_client.py`
+- Alerts: `src/accessiweather/alert_manager.py` and `src/accessiweather/alert_notification_system.py`
 
-### Application Structure
-- **Entry Point**: `src/accessiweather/app.py` - Main `AccessiWeatherApp(toga.App)` class
-- **Config Management**: `ConfigManager` (JSON-based, uses `toga.App.paths.config`)
-  - Portable mode supported: checks for `portable.txt` flag to use local config directory
-  - Settings: `AppSettings` model with validation in `config/settings.py`
-  - Locations: `LocationOperations` in `config/locations.py`
-- **UI Builder**: `ui_builder.py` creates main window and menu system
-- **Display Layer**: `WeatherPresenter` formats weather data for screen readers
-- **Background Tasks**: Periodic updates via `asyncio.create_task` in `background_tasks.py`
+Weather source strategy:
 
-### API Structure
-- `api/nws/`: National Weather Service API wrappers (alerts, forecasts, gridpoints)
-- `api/openmeteo_wrapper.py`: Open-Meteo integration
-- `api/visualcrossing/`: Visual Crossing API (alerts, historical data)
-- `api/base_wrapper.py`: Shared HTTP client patterns with retries
+- NWS for supported US locations.
+- Open-Meteo for international locations and non-alert fallback data.
+- Visual Crossing for optional enhanced alert/weather data when configured.
 
-## Toga Framework Specifics
+## Development Commands
 
-### Critical Patterns
-1. **OptionContainer API**: Use `option_container.content.append(title, widget)` with TWO separate arguments, NOT `.add(title, widget)` or tuple format
-2. **Accessibility**: ALL UI elements MUST have `aria_label` and `aria_description` attributes
-3. **Testing**: Use Toga dummy backend (`toga_dummy` package) for unit tests
-   - Set `TOGA_BACKEND=toga_dummy` environment variable
-   - Fallback to `toga_winforms` on Windows if dummy unavailable
-4. **Async Operations**: Toga uses `asyncio` - all long-running operations must be async
-5. **Main Thread**: UI updates must happen on main thread, use `app.add_background_task()` for background work
-
-### Common Gotchas
-- OptionContainer: Use `.content.append(title, widget)` with two arguments, NOT tuple format `(title, widget)`
-- Toga Selection widget (dropdown) uses `.items` list and `.value` property
-- **Error Dialogs**: Use built-in `await app.main_window.error_dialog("Title", "Message")` instead of custom dialog classes
-- **Info Dialogs**: Use `await app.main_window.info_dialog("Title", "Message")` for informational messages
-- **Question Dialogs**: Use `await app.main_window.question_dialog("Title", "Question")` for yes/no prompts
-- Modal dialogs: Create with `toga.Window`, show with `.show()`, close with `.close()`
-- Focus management: Call `.focus()` on widgets for accessibility (may fail silently on some platforms)
-
-## Development Workflow
-
-### Local Development
 ```bash
-# Run app in development mode (hot reload)
-briefcase dev
-
-# Run tests (uses pytest with Toga dummy backend)
-pytest -v -p pytest_asyncio
-
-# Auto-fix linting issues and format code (run BEFORE committing)
-ruff check --fix .
-ruff format .
-
-# Or run both in one line (recommended workflow)
+uv run accessiweather
+pytest -n auto -v --tb=short
 ruff check --fix . && ruff format .
-
-# Type checking (optional, can be noisy)
 pyright
+python installer/build_nuitka.py
 ```
 
-### Pre-Commit Hooks
-- Auto-formats code with `ruff format` (line length 100)
-- Auto-fixes linting issues with `ruff check --fix`
-- Runs last-failed unit tests (`pytest --lf --ff -m "unit"`)
-- Type checks with pyright (excludes tests/)
-- **Important**: Pre-commit will auto-stage formatted files
+## wxPython Patterns
 
-### Build & Package
-```bash
-# Create platform-specific app bundle
-briefcase create
+- Keep UI work on the wx main thread; use `wx.CallAfter` when crossing thread boundaries.
+- Prefer existing `src/accessiweather/ui/` dialogs and helpers over adding new UI patterns.
+- Add accessible names/descriptions/status text for new interactive controls.
+- Preserve keyboard access and Escape/Cancel behavior in dialogs.
+- Tests use the wx stub in `tests/conftest.py` by default. Use `ACCESSIWEATHER_ALLOW_REAL_WX_IN_TESTS=1` only for intentional real-wx checks.
 
-# Build installer (MSI on Windows, DMG on macOS, AppImage on Linux)
-briefcase build
+## Testing
 
-# Package for distribution
-briefcase package
-```
+- Unit tests should mock external APIs and OS services.
+- Add focused regression tests before fixes.
+- Use integration tests only when cassette-backed or explicitly intended to touch live services.
+- Run diff coverage for PRs when the CI gate is likely to care.
 
-### Testing Conventions
-- **Unit tests**: Fast, isolated tests in `tests/test_*.py`
-- **Integration tests**: Test real API calls (marked with `@pytest.mark.integration`)
-- **Fixtures**: Reusable test fixtures in `tests/toga_test_helpers.py`
-  - `DummyConfigManager`: Mock config manager for testing
-  - `WeatherDataFactory`: Creates mock weather data
-  # AccessiWeather — AI coding agent quick guide
+## Conventions
 
-  This file highlights the repository-specific patterns, workflows and commands an AI coding agent should follow to be immediately productive.
-
-  **Architecture & key locations**
-  - Entry: `src/accessiweather/app.py` (main `AccessiWeatherApp`)
-  - API wrappers: `api/` (see `api/base_wrapper.py` for shared HTTP client patterns)
-  - Config: `config/settings.py`, `config/locations.py` and `ConfigManager` (uses `toga.App.paths.config`)
-  - UI: `ui_builder.py`, `dialogs/` and `WeatherPresenter` for screen-reader formatting
-  - Background tasks: `background_tasks.py` and `WeatherDataCache` / `WeatherClient` for data flow
-
-  **Must-follow code patterns (examples)**
-  - OptionContainer: use `option_container.content.append(title, widget)` (two args). Do NOT pass a tuple or use `.add()`.
-  - Accessibility: every control must set `aria_label` and `aria_description` (see `docs/ACCESSIBILITY.md`).
-  - Error handling: use `await app.main_window.error_dialog("Title", "Message")` instead of custom dialog classes.
-  - Async/Toga rules: make long-running code `async`, `await` calls, and use `app.add_background_task()` or `asyncio.create_task()` for background work. Do not use `asyncio.run()` in Toga UI code.
-
-  **Testing & local dev commands**
-  - Run app (dev): `briefcase dev`
-  - Tests: `pytest -v -p pytest_asyncio` (use `TOGA_BACKEND=toga_dummy` for unit tests)
-  - Lint & format: `ruff check --fix . && ruff format .` (pre-commit auto-stages changes)
-  - Type check (optional): `pyright`
-
-  **When adding features**
-  - Settings UI: add widget attribute to `SettingsDialog`, update `dialogs/settings_tabs.py`, and wire `apply_settings_to_ui()` / `collect_settings_from_ui()` (see existing pattern in `dialogs/`).
-  - New API integration: add module under `api/`, implement async client (use `httpx.AsyncClient`), then integrate with `WeatherClient` and `WeatherDataCache`.
-
-  **Important conventions & gotchas**
-  - Line length: 100 (see `pyproject.toml`/ruff config).
-  - Use modern type hints: `dict[str, Any]` and `from __future__ import annotations` where applicable.
-  - Config: always call `config_manager.load_config()` before reading settings; portable mode checks `portable.txt`.
-  - Alerts: Visual Crossing API requires an API key (gracefully degrade if missing). Rate-limit notifications.
-
-  **Files to inspect for examples**
-  - `src/accessiweather/app.py`, `api/base_wrapper.py`, `config/settings.py`, `dialogs/settings_handlers.py`, `background_tasks.py`, `tests/toga_test_helpers.py`
-
-  If anything here is unclear or you want more detail on a specific area (tests, packaging, accessibility patterns), tell me which section to expand.
-```
+- Use modern type hints and `from __future__ import annotations`.
+- Keep line length at 100 and let Ruff format imports/code.
+- Update `CHANGELOG.md` for user-visible behavior.
+- Use conventional commit messages and PR titles.
+- Use `gh api` REST PATCH for PR metadata edits.