fix(location): name international current locations#696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
.venv\Scripts\python.exe -m pytest tests\test_location_manager_address_geocoding.py tests\test_current_location.py -q.venv\Scripts\python.exe -m ruff check src\accessiweather\location_manager.py tests\test_location_manager_address_geocoding.py.venv\Scripts\pyright.exe src\accessiweather\location_manager.py.venv\Scripts\python.exe -m pytest tests\test_location_manager_address_geocoding.py tests\test_current_location.py tests\test_config_manager.py::TestConfigManager::test_update_location_details_changes_coordinates_and_clears_zone_metadata tests\test_config_manager.py::TestConfigManager::test_update_location_details_keeps_zone_metadata_when_coordinates_match tests\test_config_manager.py::TestConfigManager::test_update_location_details_nonexistent_returns_false tests\test_config_manager.py::TestConfigManager::test_update_location_details_rejects_duplicate_display_name tests\test_all_locations_view.py::TestEditLocation --cov=accessiweather --cov-report=xml:reports\coverage-international-location.xml -quvx diff-cover reports\coverage-international-location.xml --compare-branch=origin/dev --fail-under=80 --exclude "*/accessiweather/ui/*"