Skip to content

fix(location): name international current locations#696

Merged
Orinks merged 1 commit into
devfrom
codex/international-current-location
May 28, 2026
Merged

fix(location): name international current locations#696
Orinks merged 1 commit into
devfrom
codex/international-current-location

Conversation

@Orinks
Copy link
Copy Markdown
Owner

@Orinks Orinks commented May 28, 2026

Summary

  • Adds an OpenStreetMap Nominatim reverse-geocoding fallback after NWS cannot name detected coordinates
  • Builds editable saved-location labels for international detected locations and preserves country codes when available
  • Keeps unavailable, timeout, and invalid-response cases graceful so manual entry remains available

Test Plan

  • .venv\Scripts\python.exe -m pytest tests\test_location_manager_address_geocoding.py tests\test_current_location.py -q
  • .venv\Scripts\python.exe -m ruff check src\accessiweather\location_manager.py tests\test_location_manager_address_geocoding.py
  • .venv\Scripts\pyright.exe src\accessiweather\location_manager.py
  • .venv\Scripts\python.exe -m pytest tests\test_location_manager_address_geocoding.py tests\test_current_location.py tests\test_config_manager.py::TestConfigManager::test_update_location_details_changes_coordinates_and_clears_zone_metadata tests\test_config_manager.py::TestConfigManager::test_update_location_details_keeps_zone_metadata_when_coordinates_match tests\test_config_manager.py::TestConfigManager::test_update_location_details_nonexistent_returns_false tests\test_config_manager.py::TestConfigManager::test_update_location_details_rejects_duplicate_display_name tests\test_all_locations_view.py::TestEditLocation --cov=accessiweather --cov-report=xml:reports\coverage-international-location.xml -q
  • uvx diff-cover reports\coverage-international-location.xml --compare-branch=origin/dev --fail-under=80 --exclude "*/accessiweather/ui/*"

@Orinks Orinks merged commit 5e036c7 into dev May 28, 2026
3 checks passed
@Orinks Orinks deleted the codex/international-current-location branch May 28, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant