fix: quiet hours crash on save and missing startup persistence (#18)#20
Merged
fix: quiet hours crash on save and missing startup persistence (#18)#20
Conversation
Orinks
force-pushed
the
fix/quiet-hours-crash
branch
2 times, most recently
from
bc3dfcc to
cfc5294
Compare
- Add set_quiet_hours() method and quiet_hours_enabled property to ClockService - Add quiet hours save/restore to app.py _load_config() and save_config() - Add tests for new method and property Fixes #18
Orinks
force-pushed
the
fix/quiet-hours-crash
branch
from
cfc5294 to
3bf0e40
Compare
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Problem: Settings dialog called
set_quiet_hours()and referencedquiet_hours_enabledonClockService, but neither existed — causingAttributeErrorwhen saving quiet hours settings. Quiet hours also weren't restored on startup.Changes:
set_quiet_hours(start, end)method toClockServicequiet_hours_enabledproperty (getter disables by clearing start/end)app._sync_service_settings()so config is restored on loadTesting: Lint passes. New tests cover set/get/disable flows.