-
Notifications
You must be signed in to change notification settings - Fork 86
package-lock check adding #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v8/develop
Are you sure you want to change the base?
Conversation
AnaDjokovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, just check and resolve the copilot suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
package-lock check adding
Note
Medium Risk
Mostly CI/test-only, but adds new shutdown paths for HTTP and libp2p that could affect resource cleanup and port reuse if invoked outside tests.
Overview
Adds a new CI workflow (
check-package-lock.yml) that fails builds whenpackage-lock.jsonis missing/empty, and whenpackage.jsonchanges without an accompanying lockfile update; it also validates lockfile sync vianpm ci --dry-run.Improves BDD test stability by adding
redisto thechecks.ymlservice stack and by implementing explicit teardown:ExpressHttpClient/HttpClientModuleManagernow supportclose(),Libp2pService/NetworkModuleManagersupportstop(), andMockOTNode.stop()shuts down the command executor, HTTP server, libp2p, and background intervals (with sharedcleanupBlockchainIntervalsused byProofingServiceandClaimRewardsService). Test hooks were updated to await orderly node shutdown, make triple store cleanup best-effort, and ignore a couple expected libp2p unhandled-rejection codes in the test environment.Written by Cursor Bugbot for commit 18820b1. This will update automatically on new commits. Configure here.