Skip to content

Conversation

@Bojan131
Copy link
Collaborator

@Bojan131 Bojan131 commented Jan 21, 2026

package-lock check adding


Note

Medium Risk
Mostly CI/test-only, but adds new shutdown paths for HTTP and libp2p that could affect resource cleanup and port reuse if invoked outside tests.

Overview
Adds a new CI workflow (check-package-lock.yml) that fails builds when package-lock.json is missing/empty, and when package.json changes without an accompanying lockfile update; it also validates lockfile sync via npm ci --dry-run.

Improves BDD test stability by adding redis to the checks.yml service stack and by implementing explicit teardown: ExpressHttpClient/HttpClientModuleManager now support close(), Libp2pService/NetworkModuleManager support stop(), and MockOTNode.stop() shuts down the command executor, HTTP server, libp2p, and background intervals (with shared cleanupBlockchainIntervals used by ProofingService and ClaimRewardsService). Test hooks were updated to await orderly node shutdown, make triple store cleanup best-effort, and ignore a couple expected libp2p unhandled-rejection codes in the test environment.

Written by Cursor Bugbot for commit 18820b1. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@AnaDjokovic AnaDjokovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just check and resolve the copilot suggestions

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants