Java: DENM v1.1.3 refactoring and new DENM v2.2.0#502
Java: DENM v1.1.3 refactoring and new DENM v2.2.0#502mathieu1fb merged 12 commits intoOrange-OpenSource:masterfrom
Conversation
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
…asses Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
…eration Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
…ent classes for v1.1.3 and v2.2.0 Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Use full names including "container" instead of short versions. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Handle new DENM implementations to process them into RoadHazard objects. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
fredOG-2A1
left a comment
There was a problem hiding this comment.
Hi.
Done with code review.
Just a question, for DENM version 1.1.3 it is the latest and is compatible with versions from 1.0.0 to 1.1.3 if any?
About to perform the requested tests.
Hi Frédéric ! Great :) DENM v1.1.3 is the latest v1 version, and v2.2.0 is the latest v2 version for the time being. Our oldest tracked DENM version is v1.1.0 which is most likely compatible with v1.1.3. |
|
Using 1.1.3 version of the DENM: Raw DENM v1.1.3: DenmEnvelope113[type=denm, origin=self, version=1.1.3, sourceUuid=uuid, timestamp=1776081326301, path=null, message=DenmMessage113[protocolVersion=2, stationId=123456, managementContainer=ManagementContainer[actionId=ActionId[originatingStationId=123456, sequenceNumber=11441], detectionTime=703166126304, referenceTime=703166126304, termination=null, eventPosition=ReferencePosition[latitude=486260590, longitude=22479040, altitude=0], relevanceDistance=null, relevanceTrafficDirection=null, validityDuration=10, transmissionInterval=null, stationType=5, confidence=null], situationContainer=SituationContainer[informationQuality=7, eventType=EventType[cause=2, subcause=0], linkedCause=null], locationContainer=null, alacarteContainer=null]] Using the 2.2.0 version: Raw DENM v2.2.0: DenmEnvelope220[messageType=denm, sourceUuid=uuid, timestamp=1776081527964, version=2.2.0, path=null, message=DenmMessage220[protocolVersion=2, stationId=123456, managementContainer=ManagementContainer[actionId=ActionId[originatingStationId=123456, sequenceNumber=23123], detectionTime=703166327965, referenceTime=703166327966, termination=null, eventPosition=ReferencePosition[latitude=486260590, longitude=22479040, positionConfidenceEllipse=PositionConfidenceEllipse[semiMajor=4095, semiMinor=4095, semiMajorOrientation=3601], altitude=Altitude[value=0, confidence=15]], awarenessDistance=null, trafficDirection=null, validityDuration=10, transmissionInterval=null, stationType=5], situationContainer=SituationContainer[informationQuality=7, eventType=CauseCode[cause=2, subcause=0], linkedCause=null, eventZone=null, linkedDenms=null, eventEnd=null], locationContainer=null, alacarteContainer=null]] Seems good to me. |
…ls into EtsiConverter + DenmHelper Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
61dfe3e to
43f6978
Compare
Looks fine, thanks for the review! You should now be able to approve the PR ;) |
What's new
Close #500
What to do
After reviewing code changes:
Iot3MobilityExampleclass in theexamplesmodule, and set appropriate values for the following fields:Iot3MobilityExamplefor a few seconds.DenmVersion.V1_1_3parameter in thesendTestDenm(...)method byCpmVersion.V2_2_0.Iot3MobilityExamplefor a few seconds.Expected results
Note: it is normal if source_uuid, station_id and timestamps differ in your test.