Making recordRequests a bool instead of a string#3
Open
misirlou-tg wants to merge 2 commits intoOpus-Software:masterfrom
Open
Making recordRequests a bool instead of a string#3misirlou-tg wants to merge 2 commits intoOpus-Software:masterfrom
misirlou-tg wants to merge 2 commits intoOpus-Software:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, when adding an imposter the
recordRequestsproperty is being sent to mb as a string, not a boolean. If an empty string is sent mb treats this asfalse, any non-empty string it treats astrue.This make for a confusing user experience, when you open the new imposter form neither radio button is selected (which will be sent to mb as an empty string). If the user clicks on True or False a non-empty string will be sent to mb, and the imposter will be created with
recordRequestsset totrue.With this change the radio button defaults to False and True/False works as expected.