Node 14: Upgrade greenlock and other dependencies#270
Open
JumpLink wants to merge 9 commits intoOptimalBits:masterfrom
Open
Node 14: Upgrade greenlock and other dependencies#270JumpLink wants to merge 9 commits intoOptimalBits:masterfrom
JumpLink wants to merge 9 commits intoOptimalBits:masterfrom
Conversation
manast
approved these changes
Jan 13, 2021
Member
manast
left a comment
manast
left a comment
There was a problem hiding this comment.
Looks great, thanks for the PR, highly appreciated.
Author
|
Okay nice @manast, with my last commit I have also removed the renew logic but kept the parameters of the |
…ead of node_modules/redbird
Author
|
@manast Greenlock requires two config files:
which are automatically generated by Greenlock if they are not found. Before my last commit they were created in the I hope everything works now. I would be happy about improvements, tests and feedback. |
sheksushant
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have upgrade greenlock (and this plugins) to v4 to get redbird working on Node 14.
This has other advantages, greenlock renews the certificates by itself, so the renewal logic can be removed (but I didn't do it to not break anything and to stay downward compatible).
Other changes: