opts for manually choosing container network, port and path#244
Open
paulll wants to merge 1 commit intoOptimalBits:masterfrom
Open
opts for manually choosing container network, port and path#244paulll wants to merge 1 commit intoOptimalBits:masterfrom
paulll wants to merge 1 commit intoOptimalBits:masterfrom
Conversation
Member
|
Could you please explain why you propose this change? thanks. |
Author
|
Some of my containers have port 22 open, and I haven't found any other way to get redbird to choose another one |
Member
|
reason I am not mergin this yet is that I am not sure if this can have consequences for existing users, would be easier if the preferred ports could be passed as an optional parameter. |
d2cefd1 to
43a52cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.