Rework Optable API configuration and request forming #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `app` path parameter. Add `tenant` and `originSlug` parameters. Make host dynamic and apply path `v2`. Move all configuration parameters in Config class and reuse it everywhere. Separate `GoogleAdIdManager` and `LocalStorage` logic from the network client. Rename `Client` to `NetworkClient`. Move hash logic to separate `TypeHasher` class. Separate network interceptors. Refactor SDK code.
Support secret api keys. Fetch user agent only once. Write unit tests with the mock web server.
justadreamer
requested changes
Dec 15, 2025
android_sdk/src/main/java/co/optable/android_sdk/core/UserAgentHolder.kt
Show resolved
Hide resolved
Remove custom network Adapter. Use native Retrofit adapter. Add Kotlin suspension.
Migrate from TypeHasher to IdentifiersEncoder. Add all identifier types. Cover with unit tests.
Use callbacks API. Rewrite demo apps to make the examples more readable. Use shorter logs. Create Optable SDK instance once during application creation and reuse everywhere. Move fragments to one folder.
Add missed "reg" query param. Make Consents mutable. Provide `receiveGaidAutomatically` property. Refactor main methods javadoc.
justadreamer
requested changes
Jan 11, 2026
DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/TheApplication.java
Outdated
Show resolved
Hide resolved
DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/ui/GamBannerFragment.java
Show resolved
Hide resolved
| private void applyOptableToGam(AdManagerAdRequest.Builder builder, @Nullable OptableTargeting targeting) { | ||
| if (targeting == null) return; | ||
|
|
||
| Map<String, List<String>> audiences = targeting.getAudiences(); |
Collaborator
There was a problem hiding this comment.
this (incorrect) code of generating a GAM kv pair is repeated - perhaps it should become part of the Optable SDK library gamTargeting() function?
Collaborator
Author
There was a problem hiding this comment.
After renaming audiences to gamTargeting, maybe should I introduce some OptableSDK.applyGamTargeting(gamAdRequestBuilder, optableResult)?
DemoApp/DemoAppKotlin/app/src/main/java/co/optable/androidsdkdemo/ui/GamBannerFragment.kt
Show resolved
Hide resolved
| result.addIfNotNull(IPV4, ids.ipv4Address, ::removeWhitespaces) | ||
| result.addIfNotNull(IPV6, ids.ipv6Address, ::normalize) | ||
| result.addIfNotNull(IDFA, ids.appleIdfa, ::normalize) | ||
| result.addIfNotNull(GAID, ids.googleGaid, ::normalize) |
Collaborator
There was a problem hiding this comment.
do we need to normalize GAID - maybe it is worth passing it as is, as system returns it?
Collaborator
Author
There was a problem hiding this comment.
It can be received from OptableSDK.tryIdentifyFromUrl(), so it can be uppercased or with some wrong characters. And that's how the legacy logic worked.
android_sdk/src/main/java/co/optable/android_sdk/core/IdentifiersEncoder.kt
Show resolved
Hide resolved
| * We first convert the Uri to a lowercase string then re-parse it so that we are | ||
| * not dependent on case-sensitivity of the "oeid" query parameter | ||
| */ | ||
| fun eidFromUrl(urlString: String): String? { |
Collaborator
There was a problem hiding this comment.
this name is a bit confusing, as eid is an extended id in OpenRTB, here we talk rather about a prefixed ID param
Collaborator
Author
There was a problem hiding this comment.
Renamed to prefixedIdFromUrl.
android_sdk/src/main/java/co/optable/android_sdk/OptableIdentifiers.kt
Outdated
Show resolved
Hide resolved
android_sdk/src/test/java/co/optable/android_sdk/OptableIdentifiersTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
Breaking changes:
apppath parameter.tenantandoriginSlugquery parameters.v2.Other features:
apiKey.Configclass and reuse it everywhere.GoogleAdIdManagerandLocalStoragelogic from the network client.ClienttoNetworkClient.TypeHasherclass.