Replace individual LogEntry URLs with collection LogEntries#4
Merged
Conversation
Individual log entries don't typically have meaningful URLs in log systems like Datadog/Kibana. Instead, URLs should point to the query results or filtered views that contain these entries. This change aligns the log API with the metrics pattern where MetricSeries has URLs, not individual MetricPoints, providing a more logical and useful interface for external linking.
Greptile SummaryThis PR refactors the log API to move the URL field from individual Key Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant API as API Handler
participant Provider as Log Provider
participant External as External Log System
Client->>API: POST /logs/query (LogQuery)
API->>API: Validate query
API->>Provider: Query(ctx, LogQuery)
Provider->>External: Query logs (provider-specific API)
External-->>Provider: Raw log results
Provider->>Provider: Normalize to LogEntry[]
Provider->>Provider: Wrap in LogEntries{Entries, URL}
Provider-->>API: LogEntries (with collection URL)
API-->>Client: JSON response {entries: [...], url: "..."}
Note over Provider,External: URL points to query results view<br/>in source system (e.g., Datadog dashboard)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual log entries don't typically have meaningful URLs in log systems like Datadog/Kibana. Instead, URLs should point to the query results or filtered views that contain these entries. This change aligns the log API with the metrics pattern where MetricSeries has URLs, not individual MetricPoints, providing a more logical and useful interface for external linking.