Fix concurrency, context propagation, and code quality issues #274
+94
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Propagate context to K8s operations instead of context.TODO() for graceful cancellation - Replace busy-wait loops with tickers in LogStreamer for efficiency - Add sync.Once to API client singletons for thread-safe initialization - Add context cancellation check in leader election loop for responsive shutdown - Remove redundant cobra.CheckErr call in API client validation - Fix redundant slice re-assignment in opslevelAppendLogProcessor - Extract container name constants in k8s.go for maintainability Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jasonopslevel
commented
Jan 21, 2026
| s.logger.Trace().Msg("Shutting down log streamer ...") | ||
| return | ||
| default: | ||
| case <-ticker.C: |
Contributor
Author
There was a problem hiding this comment.
This is the main offender for the performance issue, doing a busy-wait for log streaming. This makes the cpu go from 100% -> less than 1% per job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changelog
changieentryTophatting