Add new job-agent-mode flag #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pkg/k8s.go
Outdated
| } | ||
|
|
||
| func isCodingAgentJob(job opslevel.RunnerJob) bool { | ||
| return strings.Contains(job.Image, "coding-agent") |
Contributor
Author
There was a problem hiding this comment.
Think I'm going to set this to the exact image name/version before pushing up. So that our release sequence will be:
- Merge
opslevel-containersMR with new image - update this branch to have that exact image name, then merge this
a. At this stage, runner behaviour is unchanged for existing opslevel codebase - Now bump the image in OpsLevel monolith - then runner will run it with privileges
a. we can test on staging at this point - Circle back and change this opslevel-runner check back to
coding-agentmore generically
Basically want to avoid the current non-containerized version running in privileged mode. Open to other ideas!
derek-etherton-opslevel
force-pushed
the
14161-coding-agent-permissions
branch
from
f0c5be1 to
5f6d11a
Compare
| var containerSecurityContext *corev1.SecurityContext | ||
| if isCodingAgent { | ||
| // Coding agent jobs need privileged mode for creating containers within container | ||
| privileged := true |
Contributor
Author
There was a problem hiding this comment.
We have an existing network policy for runner-jobs blocking egress to internal networks: https://gitlab.com/jklabsinc/opslevel-kubernetes/-/tree/main/clusters/new-prod-runners/runner-jobs?ref_type=heads
derek-etherton-opslevel
force-pushed
the
14161-coding-agent-permissions
branch
from
1e28d55 to
0bce102
Compare
jasonopslevel
approved these changes
Dec 10, 2025
| rootCmd.PersistentFlags().String("job-pod-workdir", "/jobs", "The job pod working directory.") | ||
| rootCmd.PersistentFlags().Int("job-pod-log-max-interval", 30, "The max amount of time between when pod logs are shipped to OpsLevel. Works in tandem with 'job-pod-log-max-size'") | ||
| rootCmd.PersistentFlags().Int("job-pod-log-max-size", 1000000, "The max amount in bytes to buffer before pod logs are shipped to OpsLevel. Works in tandem with 'job-pod-log-max-interval'") | ||
| rootCmd.PersistentFlags().Bool("job-agent-mode", false, "Enable agent mode with privileged security context for Container-in-Container support. WARNING: This grants elevated privileges and should only be enabled for trusted workloads.") |
Contributor
Author
There was a problem hiding this comment.
now that we're using a job arg, we can be oober confident that nothing will use this mode until we explicitly add it to opslevel-kubernetes 👍
so sequencing will be:
- ship new image to ECR (done)
- ship this PR - no effect since flag isn't used
- Test on staging, then ship the OpsLevel MR
- Once changes are live, fast follow with an opslevel-kubernetes MR adding the
--job-agent-modeflag
a. since the feature isn't "on" yet we can get away with this teeny gap.
derek-etherton-opslevel
changed the title
derek-etherton-opslevel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
cd src->go build -o /tmp/opslevel-runner-local.opslevel-runner.env.localto haveOPSLEVEL_RUNNER_PATH=/tmp/opslevel-runner-local./bin/dev-serverChangelog
changieentryTophatting