Skip to content

Correctly query for parent on service, not for system. #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewstillv15 merged 1 commit into from
Jan 15, 2026
Merged

Correctly query for parent on service, not for system. #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,15 +169,15 @@ func (service *Service) GetSystem(client *Client, variables *PayloadVariables) (
var q struct {
Account struct {
Service struct {
System System `graphql:"system"`
System System `graphql:"parent"`
} `graphql:"service(id: $service)"`
}
}
if service.Id == "" {
return nil, fmt.Errorf("unable to get system, invalid Service id: '%s'", service.Id)
}
if variables == nil {
variables = client.InitialPageVariablesPointer()
variables = &PayloadVariables{}
}
(*variables)["service"] = service.Id
if err := client.Query(&q, *variables, WithName("ServiceSystemGet")); err != nil {
Expand Down
6 changes: 3 additions & 3 deletions service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ func TestServiceTags(t *testing.T) {
func TestServiceSystem(t *testing.T) {
// Arrange
request := autopilot.NewTestRequest(
`query ServiceSystemGet($after:String!$first:Int!$service:ID!){account{service(id: $service){system{id,aliases,description,htmlUrl,managedAliases,name,note,owner{... on Team{teamAlias:alias,id}},parent{id,aliases,description,htmlUrl,managedAliases,name,note,owner{... on Team{teamAlias:alias,id}}}}}}}`,
`{ {{ template "first_page_variables" }}, "service": "Z2lkOi8vb3BzbGV2ZWwvU2VydmljZS85NjQ4" }`,
`{ "data": { "account": { "service": { "system": {{ template "system1_response" }} } } } }`,
`query ServiceSystemGet($service:ID!){account{service(id: $service){parent{id,aliases,description,htmlUrl,managedAliases,name,note,owner{... on Team{teamAlias:alias,id}},parent{id,aliases,description,htmlUrl,managedAliases,name,note,owner{... on Team{teamAlias:alias,id}}}}}}}`,
`{ "service": "Z2lkOi8vb3BzbGV2ZWwvU2VydmljZS85NjQ4" }`,
`{ "data": { "account": { "service": { "parent": {{ template "system1_response" }} } } } }`,
)
client := BestTestClient(t, "service/system", request)
// Act
Expand Down
Loading