Skip to content

Breaking change for unification #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rocktavious merged 1 commit into from
Aug 12, 2025
Merged

Breaking change for unification #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Refactor-20250812-152151.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Refactor
body: 'BREAKING CHANGE: Refactor the automatic external_kind calculation for when posting to custom data integration so that "/" are not turned into "_"'
time: 2025-08-12T15:21:51.825057-04:00
4 changes: 2 additions & 2 deletions workers/k8s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"encoding/json"
"fmt"
"net/url"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -75,12 +76,11 @@ func (s *K8SWorker) parse(item *unstructured.Unstructured) (opslevel.JSON, error
}

func (s *K8SWorker) sendEvent(kind string, id string, value *unstructured.Unstructured) {
kind = strings.Replace(kind, "/", "_", -1)
if viper.GetBool("dry-run") {
log.Info().Msgf("[DRYRUN] POST %s | %s", kind, id)
log.Debug().Msgf("\t%#v", value)
} else {
url := fmt.Sprintf("%s?external_kind=%s", s.integration, kind)
url := fmt.Sprintf("%s?external_kind=%s", s.integration, url.QueryEscape(kind))
resp, err := s.restClient.R().SetBody(value).Post(url)
if err != nil {
log.Error().Err(err).Msgf("error during post")
Expand Down