Skip to content

Comments

fix(adapter): re-export adapter classes from package entry points#343

Merged
pasevin merged 1 commit intomainfrom
fix/adapter-class-exports
Feb 20, 2026
Merged

fix(adapter): re-export adapter classes from package entry points#343
pasevin merged 1 commit intomainfrom
fix/adapter-class-exports

Conversation

@pasevin
Copy link
Collaborator

@pasevin pasevin commented Feb 20, 2026

Summary

  • Re-export EvmAdapter, StellarAdapter, and PolkadotAdapter classes from their respective package entry points (index.ts)
  • These exports were accidentally removed during the ecosystemDefinition refactor in feat: add EVM adapter access control module #338, breaking exported app builds that import adapter classes directly
  • The MidnightAdapter was unaffected as it still had export * from './adapter'

Root Cause

PR #338 refactored adapters to use the ecosystemDefinition pattern with a createAdapter factory for the builder app's lazy loading. During this refactor, the export { XAdapter } lines were replaced with import { XAdapter } (for internal use in createAdapter) but the re-export was not preserved. The exported app code generator produces import { EvmAdapter } from '...' which requires the class to be publicly exported.

Test plan

  • All three adapter packages build successfully with tsup
  • Adapter classes confirmed present in generated .d.ts type definitions
  • Pre-commit hooks pass (lint, format, adapter compliance)
  • CI passes
  • Verify exported app builds for EVM, Stellar, and Polkadot ecosystems

EvmAdapter, StellarAdapter, and PolkadotAdapter were accidentally
made internal during the ecosystemDefinition refactor in #338.
Exported apps import these classes directly and fail to build
without the public re-exports.
@pasevin pasevin requested a review from a team as a code owner February 20, 2026 10:23
@pasevin pasevin merged commit 000c6ed into main Feb 20, 2026
11 checks passed
@pasevin pasevin deleted the fix/adapter-class-exports branch February 20, 2026 10:51
This was referenced Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant