fix(adapter): re-export adapter classes from package entry points#343
Merged
fix(adapter): re-export adapter classes from package entry points#343
Conversation
EvmAdapter, StellarAdapter, and PolkadotAdapter were accidentally made internal during the ecosystemDefinition refactor in #338. Exported apps import these classes directly and fail to build without the public re-exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvmAdapter,StellarAdapter, andPolkadotAdapterclasses from their respective package entry points (index.ts)ecosystemDefinitionrefactor in feat: add EVM adapter access control module #338, breaking exported app builds that import adapter classes directlyMidnightAdapterwas unaffected as it still hadexport * from './adapter'Root Cause
PR #338 refactored adapters to use the
ecosystemDefinitionpattern with acreateAdapterfactory for the builder app's lazy loading. During this refactor, theexport { XAdapter }lines were replaced withimport { XAdapter }(for internal use increateAdapter) but the re-export was not preserved. The exported app code generator producesimport { EvmAdapter } from '...'which requires the class to be publicly exported.Test plan
tsup.d.tstype definitions