fix(ci): skip version check on changeset-release PRs#342
Merged
Conversation
The check-versions and update-versions workflows race on changeset-release PRs. update-versions already auto-commits the corrected versions.ts, making the check redundant and causing spurious failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-versions.ymlandupdate-versions.ymlworkflows on changeset-release PRscheck-versionsjob now skips when the PR branch starts withchangeset-release/, sinceupdate-versions.ymlalready auto-commits the correctedversions.tsfor those PRsContext
When the changesets bot creates/updates the "Version Packages" PR, both
check-versionsandupdate-versionsworkflows fire concurrently.check-versionsfails becauseversions.tshasn't been updated yet, whileupdate-versionscommits the fix seconds later. The push fromupdate-versionsdoesn't always trigger new CI runs, leaving the PR stuck with a failed check.Test plan
ifcondition syntax is correct for GitHub Actionscheck-versionsis skipped on PR Version Packages #341 (changeset-release PR)check-versionsstill runs on regular PRs targeting main