fix(workflows): fix shell syntax error and correct action version comments#647
Open
LuisUrrutia wants to merge 1 commit intomainfrom
Open
fix(workflows): fix shell syntax error and correct action version comments#647LuisUrrutia wants to merge 1 commit intomainfrom
LuisUrrutia wants to merge 1 commit intomainfrom
Conversation
…ments
Fix bash bad substitution error in rc.yml where ${#$INPUT_COMMIT_SHA} crashes the validation step on invalid SHA input. Correct misleading action version comments: checkout SHA is v6.0.1 (not v4.5.4, which doesn't exist), attest-build-provenance is v3.0.0 (not main), and docker/login-action is v3.6.0 (was missing). Remove debug echo statements from release-please.yml.
WalkthroughGitHub Actions workflow files updated with action version bumps (checkout to v6.0.1, attest-build-provenance to v3.0.0), a bash parameter expansion bug fix, removal of redundant debug steps, and a documentation comment addition across six workflow files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a confirmed bash syntax error and corrects misleading action version comments across 6 workflow files.
Changes
rc.yml:39- Fix bash bad substitution error:${#$INPUT_COMMIT_SHA}→${#INPUT_COMMIT_SHA}. The incorrect syntax causes the validation step to crash with "bad substitution" instead of showing the intended error message when an invalid commit SHA is provided.Version comment corrections (verified via GitHub API):
scorecard.ymlandcodeql.yml:# v4.5.4→# v6.0.1(tag v4.5.4 does not exist)release-sbom.yml:# main→# v3.0.0foractions/attest-build-provenancerelease-docker.yml: Add# v3.6.0todocker/login-action(was missing)Cleanup: Remove debug echo statements from
release-please.yml("pr head branch name: >>>>> ...")All changes are cosmetic fixes except for the bash syntax error, which is a confirmed bug that will fail on next use.
Summary by CodeRabbit
Chores
Bug Fixes