fix: TransactionRequest TryFrom fn#170
Conversation
✅ Deploy Preview for openzeppelin-relayer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |
zeljkoX
left a comment
There was a problem hiding this comment.
hi @limyeechern
Thank you for improving the code and for your contribution!
|
CLA assistant is failing, we have fix for this in pipeline |
|
Hi @limyeechern - Thank you for your contribution. If you could rebase this to latest commit on main branch and ammend your commits to have verified signatures(signed commits ). We can merge it. Thanks once again |
5fffba4 to
193cf89
Compare
193cf89 to
a71207f
Compare
|
hi @tirumerla, my commits have been signed and i have rebased to the latest commit on main. Thank you. |
Thank you for making the changes @limyeechern ...looks like there is a test that's failing if you could take a look that would be great. |
|
Hi @limyeechern, following up on this PR. Could you rebase on the latest |
Summary
We need to decode the calldata using hex::decode for TransactionInput, otherwise estimate_gas that converts EvmTransactionData to TransactionRequest will fail
Testing Process
Checklist