eslint rule for no async in describe blocks via eslint-plugin-mocha#6438
eslint rule for no async in describe blocks via eslint-plugin-mocha#6438gonzaotc wants to merge 4 commits intoOpenZeppelin:masterfrom
Conversation
Adds the no-async-describe ESLint rule to catch async functions in describe blocks, which is a common source of test bugs. Closes OpenZeppelin#4943
…ywalkingzulu1/openzeppelin-contracts into feat/eslint-no-async-describe
🦋 Changeset detectedLatest commit: 90cb6c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
WalkthroughThis pull request introduces the Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #4943
PR Checklist
npx changeset add)