Note low level return data size check#6434
Draft
james-toussaint wants to merge 1 commit intoOpenZeppelin:masterfrom
Draft
Note low level return data size check#6434james-toussaint wants to merge 1 commit intoOpenZeppelin:masterfrom
james-toussaint wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
|
Amxx
reviewed
Mar 25, 2026
| /// | ||
| /// WARNING: Do not assume that the results are zero if `success` is false. Memory can be already allocated | ||
| /// and this function doesn't zero it out. | ||
| /// and this function doesn't zero it out. Similarly, if `success` is true consider checking the return data size |
Collaborator
There was a problem hiding this comment.
Maybe its not worth distinguishing success values
/// WARNING: Do not assume that the results are zero if the call doesn't return data. Memory can be already allocated
/// and this function doesn't zero it out. Consider checking the return data size using {returnDataSize()} to check
/// the results space was writen by the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes L-28
PR Checklist
npx changeset add)