Document that ReentrancyGuardTransient and ReentrancyGuard are not interoperable#6430
Document that ReentrancyGuardTransient and ReentrancyGuard are not interoperable#6430arr00 wants to merge 2 commits intoOpenZeppelin:masterfrom
ReentrancyGuardTransient and ReentrancyGuard are not interoperable#6430Conversation
|
WalkthroughThis pull request adds clarifying documentation to two reentrancy guard contracts. A Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
|
I'm not sure we need to worry about documenting this. Both version implement the @ernestognw WDYT ? |
The concern is related to diamond proxies where different facets inherit a different version of reentrancy. |
Document that
ReentrancyGuardandReentrancyGuardTransientare not interoperable.PR Checklist
npx changeset add)